third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp - Issue 2239473003: [DevTools] Removed interstatementLocation from Debugger.continueToLocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2239473003: [DevTools] Removed interstatementLocation from Debugger.continueToLocation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

index dde37c85e52aa4d2ca6e239292e85c23a0cee2b9..0ceb953618d744321c627b402b9f2c2b5ed3d7d5 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

@@ -138,7 +138,7 @@ void V8Debugger::getCompiledScripts(int contextGroupId, std::vector<std::unique_

}

-String16 V8Debugger::setBreakpoint(const String16& sourceID, const ScriptBreakpoint& scriptBreakpoint, int* actualLineNumber, int* actualColumnNumber, bool interstatementLocation)

+String16 V8Debugger::setBreakpoint(const String16& sourceID, const ScriptBreakpoint& scriptBreakpoint, int* actualLineNumber, int* actualColumnNumber)

{

v8::HandleScope scope(m_isolate);

v8::Context::Scope contextScope(debuggerContext());

@@ -147,7 +147,6 @@ String16 V8Debugger::setBreakpoint(const String16& sourceID, const ScriptBreakpo

info->Set(toV8StringInternalized(m_isolate, "sourceID"), toV8String(m_isolate, sourceID));

info->Set(toV8StringInternalized(m_isolate, "lineNumber"), v8::Integer::New(m_isolate, scriptBreakpoint.lineNumber));

info->Set(toV8StringInternalized(m_isolate, "columnNumber"), v8::Integer::New(m_isolate, scriptBreakpoint.columnNumber));

- info->Set(toV8StringInternalized(m_isolate, "interstatementLocation"), v8Boolean(interstatementLocation, m_isolate));

info->Set(toV8StringInternalized(m_isolate, "condition"), toV8String(m_isolate, scriptBreakpoint.condition));

v8::Local<v8::Function> setBreakpointFunction = v8::Local<v8::Function>::Cast(m_debuggerScript.Get(m_isolate)->Get(toV8StringInternalized(m_isolate, "setBreakpoint")));