third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h - Issue 2239313002: Hide non-composited native scrollbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

Issue 2239313002: Hide non-composited native scrollbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp ('k') | third_party/WebKit/Source/web/WebRuntimeFeatures.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

index 5f0b03677024106e859dfbb7dfce00098ebbd708..2b9ce31d72e5938a16ec0220b8010626a6712a44 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

@@ -37,7 +37,12 @@ namespace blink {

class PLATFORM_EXPORT ScrollbarThemeOverlayMock : public ScrollbarThemeOverlay {

public:

- ScrollbarThemeOverlayMock() : ScrollbarThemeOverlay(3, 4, DisallowHitTest, Color(128, 128, 128)) { }

+ ScrollbarThemeOverlayMock(bool hidden = false)

Sami 2016/08/12 11:12:27 I'd suggesting making this bool an enum instead so

Eric Seckler 2016/08/12 11:30:23 Done :)

+ : ScrollbarThemeOverlay(

+ hidden ? 0 : 3,

+ hidden ? 0 : 4,

+ DisallowHitTest,

+ hidden ? Color() : Color(128, 128, 128)) { }

private:

bool isMockTheme() const final { return true; }