third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h - Issue 2239313002: Hide non-composited native scrollbars.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h

Issue 2239313002: Hide non-composited native scrollbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp ('k') | third_party/WebKit/Source/web/WebRuntimeFeatures.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 19 matching lines...) Expand all Loading...
30	30

31 #ifndef ScrollbarThemeOverlayMock_h	31 #ifndef ScrollbarThemeOverlayMock_h

32 #define ScrollbarThemeOverlayMock_h	32 #define ScrollbarThemeOverlayMock_h

33	33

34 #include "platform/scroll/ScrollbarThemeOverlay.h"	34 #include "platform/scroll/ScrollbarThemeOverlay.h"

35	35

36 namespace blink {	36 namespace blink {

37	37

38 class PLATFORM_EXPORT ScrollbarThemeOverlayMock : public ScrollbarThemeOverlay {	38 class PLATFORM_EXPORT ScrollbarThemeOverlayMock : public ScrollbarThemeOverlay {

39 public:	39 public:

40 ScrollbarThemeOverlayMock() : ScrollbarThemeOverlay(3, 4, DisallowHitTest, C olor(128, 128, 128)) { }	40 ScrollbarThemeOverlayMock(bool hidden = false)
	Sami 2016/08/12 11:12:27 I'd suggesting making this bool an enum instead so I'd suggesting making this bool an enum instead so the call site logic becomes obvious. Eric Seckler 2016/08/12 11:30:23 Done :) Show quoted text On 2016/08/12 11:12:27, Sami wrote: > I'd suggesting making this bool an enum instead so the call site logic becomes > obvious. Done :)
	41 : ScrollbarThemeOverlay(

	42 hidden ? 0 : 3,

	43 hidden ? 0 : 4,

	44 DisallowHitTest,

	45 hidden ? Color() : Color(128, 128, 128)) { }

41	46

42 private:	47 private:

43 bool isMockTheme() const final { return true; }	48 bool isMockTheme() const final { return true; }

44 };	49 };

45	50

46 } // namespace blink	51 } // namespace blink

47 #endif // ScrollbarThemeOverlayMock_h	52 #endif // ScrollbarThemeOverlayMock_h

OLD	NEW