third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp - Issue 2239313002: Hide non-composited native scrollbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

Issue 2239313002: Hide non-composited native scrollbars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h » ('j') | third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlayMock.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

index ad0085bc03fa3b83f7b40eee9f8658455afc8529..27f0dde5aaa5408fc8ccf85bb8d92a6033482dba 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeOverlay.cpp

@@ -175,11 +175,15 @@ ScrollbarThemeOverlay& ScrollbarThemeOverlay::mobileTheme()

{

static ScrollbarThemeOverlay* theme;

if (!theme) {

- WebThemeEngine::ScrollbarStyle style = { 3, 3, 0x80808080 }; // default style

- if (Platform::current()->themeEngine()) {

- Platform::current()->themeEngine()->getOverlayScrollbarStyle(&style);

+ if (RuntimeEnabledFeatures::hideScrollbarsEnabled()) {

+ theme = new ScrollbarThemeOverlay(0, 0, ScrollbarThemeOverlay::DisallowHitTest, Color());

+ } else {

+ WebThemeEngine::ScrollbarStyle style = { 3, 3, 0x80808080 }; // default style

+ if (Platform::current()->themeEngine()) {

+ Platform::current()->themeEngine()->getOverlayScrollbarStyle(&style);

+ }

+ theme = new ScrollbarThemeOverlay(style.thumbThickness, style.scrollbarMargin, ScrollbarThemeOverlay::DisallowHitTest, Color(style.color));

}

- theme = new ScrollbarThemeOverlay(style.thumbThickness, style.scrollbarMargin, ScrollbarThemeOverlay::DisallowHitTest, Color(style.color));

}

return *theme;

}