Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2238423002: [DevTools] Generate all files in inspector_protocol. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, yuzo+watch_chromium.org, aboxhall, blink-reviews-style_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, cmumford, haraken, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, je_julie, kinuko+watch, jsbell+idb_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2240663003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Generate all files in inspector_protocol. BUG=637032 Committed: https://crrev.com/0001c863a0d8b16183a8289f00f77089a7511b1e Cr-Commit-Position: refs/heads/master@{#411913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -3707 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/DOMEditor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector.gyp View 1 chunk +23 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +3 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Allocator.h View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Allocator_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Array.h View 1 chunk +0 lines, -138 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Array_h.template View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/BackendCallback.h View 1 chunk +0 lines, -23 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/BackendCallback_h.template View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 5 chunks +89 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Collections.h View 1 chunk +0 lines, -46 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Collections_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.h View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp View 1 chunk +0 lines, -173 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template View 1 chunk +0 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_h.template View 4 chunks +11 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_cpp.template View 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_h.template View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template View 1 chunk +2 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel.h View 1 chunk +0 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel_h.template View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Imported_h.template View 1 chunk +1 line, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/InspectorProtocol_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Maybe.h View 1 chunk +0 lines, -89 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Maybe_h.template View 1 chunk +2 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Object.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Object.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Object_cpp.template View 1 chunk +0 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Object_h.template View 1 chunk +5 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Parser.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 1 chunk +0 lines, -499 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Parser_cpp.template View 1 chunk +0 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Parser_h.template View 1 chunk +4 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Platform.h View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/PlatformSTL.h View 1 chunk +0 lines, -292 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/PlatformWTF.h View 1 chunk +0 lines, -14 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Platform_h.template View 1 chunk +1 line, -5 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/String16.h View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/String16.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/String16STL.h View 1 chunk +0 lines, -102 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/String16STL.cpp View 1 chunk +0 lines, -405 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h View 1 chunk +0 lines, -111 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template View 1 chunk +0 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/String16_h.template View 3 chunks +12 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 chunk +2 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h View 1 chunk +0 lines, -187 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/ValueConversions_h.template View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Values.h View 1 chunk +0 lines, -250 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 1 chunk +0 lines, -411 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template View 4 chunks +7 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Values_h.template View 7 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/sample_config.json View 1 chunk +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h View 1 chunk +1 line, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/PlatformSTL.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/PlatformWTF.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h View 1 chunk +1 line, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/String16STL.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/String16STL.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/v8_inspector/String16WTF.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InternalValueType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InternalValueType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Regex.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/inspector_protocol_config.json View 1 chunk +12 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/v8_inspector/inspector_protocol_config_stl.json View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Inspector.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 5 chunks +106 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-12 23:30:03 UTC) #2
pfeldman
lgtm
4 years, 4 months ago (2016-08-13 00:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238423002/1
4 years, 4 months ago (2016-08-14 02:28:33 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-14 03:10:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238423002/1
4 years, 4 months ago (2016-08-14 03:38:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/273351)
4 years, 4 months ago (2016-08-14 04:46:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2238423002/1
4 years, 4 months ago (2016-08-14 04:56:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-14 07:15:47 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-14 07:17:24 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0001c863a0d8b16183a8289f00f77089a7511b1e
Cr-Commit-Position: refs/heads/master@{#411913}

Powered by Google App Engine
This is Rietveld 408576698