Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2240663003: [DevTools] Introduce config file for inspector_protocol. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2226863003
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce config file for inspector_protocol. Drive-by: fixing small issues in generator. BUG=637032 Committed: https://crrev.com/299805a3efd15f7464d2a768051b9f107adc09a4 Cr-Commit-Position: refs/heads/master@{#411898}

Patch Set 1 #

Patch Set 2 : rebased #

Messages

Total messages: 16 (9 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-12 00:20:54 UTC) #3
pfeldman
lgtm
4 years, 4 months ago (2016-08-12 18:31:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240663003/20001
4 years, 4 months ago (2016-08-13 14:17:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/273308)
4 years, 4 months ago (2016-08-13 16:21:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240663003/20001
4 years, 4 months ago (2016-08-13 16:32:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-13 17:55:31 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 17:57:33 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/299805a3efd15f7464d2a768051b9f107adc09a4
Cr-Commit-Position: refs/heads/master@{#411898}

Powered by Google App Engine
This is Rietveld 408576698