Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/task_manager/task_manager_observer.h

Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/task_manager_observer.h
diff --git a/chrome/browser/task_manager/task_manager_observer.h b/chrome/browser/task_manager/task_manager_observer.h
index c7c4f9c47539a30f27401c516aaccf74ef02c89a..73c03a77e44e735a9ae8f12ca389fe144601dc3b 100644
--- a/chrome/browser/task_manager/task_manager_observer.h
+++ b/chrome/browser/task_manager/task_manager_observer.h
@@ -25,25 +25,29 @@ using TaskIdList = std::vector<TaskId>;
enum RefreshType {
REFRESH_TYPE_NONE = 0,
REFRESH_TYPE_CPU = 1,
- REFRESH_TYPE_MEMORY = 1 << 1,
- REFRESH_TYPE_GPU_MEMORY = 1 << 2,
- REFRESH_TYPE_V8_MEMORY = 1 << 3,
- REFRESH_TYPE_SQLITE_MEMORY = 1 << 4,
- REFRESH_TYPE_WEBCACHE_STATS = 1 << 5,
- REFRESH_TYPE_NETWORK_USAGE = 1 << 6,
- REFRESH_TYPE_NACL = 1 << 7,
- REFRESH_TYPE_IDLE_WAKEUPS = 1 << 8,
- REFRESH_TYPE_HANDLES = 1 << 9,
+ REFRESH_TYPE_PHYSICAL_MEMORY = 1 << 1,
+ REFRESH_TYPE_MEMORY_DETAILS = 1 << 2,
+ REFRESH_TYPE_GPU_MEMORY = 1 << 3,
+ REFRESH_TYPE_V8_MEMORY = 1 << 4,
+ REFRESH_TYPE_SQLITE_MEMORY = 1 << 5,
+ REFRESH_TYPE_WEBCACHE_STATS = 1 << 6,
+ REFRESH_TYPE_NETWORK_USAGE = 1 << 7,
+ REFRESH_TYPE_NACL = 1 << 8,
+ REFRESH_TYPE_IDLE_WAKEUPS = 1 << 9,
+ REFRESH_TYPE_HANDLES = 1 << 10,
// Whether an observer is interested in knowing if a process is foregrounded
// or backgrounded.
- REFRESH_TYPE_PRIORITY = 1 << 10,
+ REFRESH_TYPE_PRIORITY = 1 << 11,
#if defined(OS_LINUX)
// For observers interested in getting the number of open file descriptors of
// processes.
- REFRESH_TYPE_FD_COUNT = 1 << 11,
+ REFRESH_TYPE_FD_COUNT = 1 << 12,
#endif // defined(OS_LINUX)
+
+ REFRESH_TYPE_MEMORY = REFRESH_TYPE_PHYSICAL_MEMORY |
+ REFRESH_TYPE_MEMORY_DETAILS,
};
// Defines the interface for observers of the task manager.
« no previous file with comments | « chrome/browser/task_manager/sampling/task_group.cc ('k') | chrome/browser/ui/task_manager/task_manager_table_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698