chrome/browser/ui/task_manager/task_manager_table_model.cc - Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/task_manager/task_manager_table_model.cc

Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/task_manager/task_manager_table_model.cc

diff --git a/chrome/browser/ui/task_manager/task_manager_table_model.cc b/chrome/browser/ui/task_manager/task_manager_table_model.cc

index 03c40cd01681d38de584727b9489961b90b13941..1ce189b816f6c7dd0ae5cfc47930e50bcc3027b1 100644

--- a/chrome/browser/ui/task_manager/task_manager_table_model.cc

+++ b/chrome/browser/ui/task_manager/task_manager_table_model.cc

@@ -636,13 +636,14 @@ void TaskManagerTableModel::UpdateRefreshTypes(int column_id, bool visibility) {

break;

case IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN:

+ type = REFRESH_TYPE_PHYSICAL_MEMORY;

+ break;

case IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN:

case IDS_TASK_MANAGER_SHARED_MEM_COLUMN:

case IDS_TASK_MANAGER_SWAPPED_MEM_COLUMN:

- type = REFRESH_TYPE_MEMORY;

+ type = REFRESH_TYPE_MEMORY_DETAILS;

if (table_view_delegate_->IsColumnVisible(

- IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN) ||

- table_view_delegate_->IsColumnVisible(

IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN) ||

table_view_delegate_->IsColumnVisible(

IDS_TASK_MANAGER_SHARED_MEM_COLUMN) ||

« no previous file with comments | « chrome/browser/task_manager/task_manager_observer.h ('k') | chrome/browser/win/private_working_set_snapshot.h » ('j') | no next file with comments »