Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2646)

Unified Diff: chrome/browser/task_manager/sampling/task_group.cc

Issue 2238403003: Task manager: Get physical memory efficiently for all processes from SharedSampler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/sampling/task_group.cc
diff --git a/chrome/browser/task_manager/sampling/task_group.cc b/chrome/browser/task_manager/sampling/task_group.cc
index b5581d520fdfbf340dfb6dd15f49569b10347337..5e36d732e9aa5ba72c47acae6b1f78d2347114f9 100644
--- a/chrome/browser/task_manager/sampling/task_group.cc
+++ b/chrome/browser/task_manager/sampling/task_group.cc
@@ -113,6 +113,8 @@ TaskGroup::TaskGroup(
shared_sampler_->RegisterCallbacks(
process_id_, base::Bind(&TaskGroup::OnIdleWakeupsRefreshDone,
+ weak_ptr_factory_.GetWeakPtr()),
+ base::Bind(&TaskGroup::OnPhysicalMemoryUsageRefreshDone,
weak_ptr_factory_.GetWeakPtr()));
}
@@ -251,11 +253,26 @@ void TaskGroup::OnCpuRefreshDone(double cpu_usage) {
OnBackgroundRefreshTypeFinished(REFRESH_TYPE_CPU);
}
+void TaskGroup::OnPhysicalMemoryUsageRefreshDone(int64_t physical_bytes) {
+#if defined(OS_WIN)
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ memory_usage_.physical_bytes = physical_bytes;
+ OnBackgroundRefreshTypeFinished(REFRESH_TYPE_PHYSICAL_MEMORY);
+#endif // OS_WIN
+}
+
void TaskGroup::OnMemoryUsageRefreshDone(MemoryUsageStats memory_usage) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+#if defined(OS_WIN)
+ memory_usage_.private_bytes = memory_usage.private_bytes;
+ memory_usage_.shared_bytes = memory_usage.shared_bytes;
+ OnBackgroundRefreshTypeFinished(REFRESH_TYPE_MEMORY_DETAILS);
+#else
memory_usage_ = memory_usage;
OnBackgroundRefreshTypeFinished(REFRESH_TYPE_MEMORY);
+#endif // OS_WIN
}
void TaskGroup::OnIdleWakeupsRefreshDone(int idle_wakeups_per_second) {
« no previous file with comments | « chrome/browser/task_manager/sampling/task_group.h ('k') | chrome/browser/task_manager/task_manager_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698