Merge method_counts into resource_sizes

Merge method_counts into resource_sizes

resource_size.py now also reports method counts, so no need
to run method_counts.py separately.

BUG=609365
Committed: https://chromium.googlesource.com/chromium/tools/build/+/0aba2c2011d7bf00bd42b42a5b68c3aa19b4e883

[agrieve, 2016-08-12 20:15:42]

agrieve@chromium.org changed reviewers:
+ rnephew@chromium.org

[agrieve, 2016-08-12 20:15:43]

Mostly just guessing this is the change we want.

Change assumes you're good with:
https://codereview.chromium.org/2244653003/

[agrieve, 2016-08-12 20:31:06]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[agrieve, 2016-08-12 20:31:42]

Description was changed from

==========
Add resource_sizes to chromium_perf steps for Android

BUG=609365
==========

to

==========
Add resource_sizes to chromium_perf steps for Android

BUG=609365
==========

[agrieve, 2016-08-12 20:31:42]

agrieve@chromium.org changed reviewers:
+ bpastene@chromium.org
- jbudorick@chromium.org

[agrieve, 2016-08-12 20:32:03]

On 2016/08/12 20:31:07, agrieve wrote:

[agrieve, 2016-08-13 02:03:53]

On 2016/08/12 20:32:03, agrieve wrote:
> On 2016/08/12 20:31:07, agrieve wrote:

I'll be OOO  all next week. If anyone wants to take a stab at this, please feel
free!

[rnephew (Reviews Here), 2016-08-15 14:28:49]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-08-15 15:37:43]

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/api.py:206: 'resource_sizes': {
I'm concerned that this change is going to break all of the old graphs for
method count. Is there a way for us to avoid doing so?

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (right):

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:50: tests =
[steps.ResourceSizesStep()]
I would prefer if you did this separately from the method_count merge.

[agrieve, 2016-09-02 18:23:04]

Description was changed from

==========
Add resource_sizes to chromium_perf steps for Android

BUG=609365
==========

to

==========
Merge method_counts into resource_sizes

resource_size.py now also reports method counts, so no need
to run method_counts.py separately.

BUG=609365
==========

[agrieve, 2016-09-02 18:23:18]

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_android/api.py (right):

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_android/api.py:206: 'resource_sizes': {
On 2016/08/15 15:37:43, jbudorick wrote:
> I'm concerned that this change is going to break all of the old graphs for
> method count. Is there a way for us to avoid doing so?

It certainly may, but the old data isn't super important going forward anyways
(and I don't see an easy way to have a continuous graph)

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (right):

https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:50: tests =
[steps.ResourceSizesStep()]
On 2016/08/15 15:37:43, jbudorick wrote:
> I would prefer if you did this separately from the method_count merge.

Done.

[agrieve, 2016-09-02 18:24:13]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 18:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 18:28:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 18:28:20]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2016-09-02 19:04:22]

lgtm

https://codereview.chromium.org/2238243003/diff/20001/scripts/slave/recipe_mo...
File
scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json
(right):

https://codereview.chromium.org/2238243003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json:872:
"name": "Sharded Perf Tests"
I'm concerned that this may be confusing for people, but I suppose we can try it
and adapt (e.g. by putting the run_sharded_perf_tests call into a nested step)
as necessary.

[jbudorick, 2016-09-02 19:05:23]

On 2016/09/02 18:23:18, agrieve wrote:
>
https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromium_android/api.py (right):
> 
>
https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromium_android/api.py:206: 'resource_sizes': {
> On 2016/08/15 15:37:43, jbudorick wrote:
> > I'm concerned that this change is going to break all of the old graphs for
> > method count. Is there a way for us to avoid doing so?
> 
> It certainly may, but the old data isn't super important going forward anyways
> (and I don't see an easy way to have a continuous graph)

I've found historical data to be very useful for looking at how we've changed
over time...

> 
>
https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromium_tests/chromium_perf.py (right):
> 
>
https://codereview.chromium.org/2238243003/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromium_tests/chromium_perf.py:50: tests =
> [steps.ResourceSizesStep()]
> On 2016/08/15 15:37:43, jbudorick wrote:
> > I would prefer if you did this separately from the method_count merge.
> 
> Done.

[agrieve, 2016-09-02 19:42:06]

https://codereview.chromium.org/2238243003/diff/20001/scripts/slave/recipe_mo...
File
scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json
(right):

https://codereview.chromium.org/2238243003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json:872:
"name": "Sharded Perf Tests"
On 2016/09/02 19:04:22, jbudorick wrote:
> I'm concerned that this may be confusing for people, but I suppose we can try
it
> and adapt (e.g. by putting the run_sharded_perf_tests call into a nested step)
> as necessary.

It's certainly confusing.

[agrieve, 2016-09-02 19:42:15]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-09-02 19:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 19:46:07]

Description was changed from

==========
Merge method_counts into resource_sizes

resource_size.py now also reports method counts, so no need
to run method_counts.py separately.

BUG=609365
==========

to

==========
Merge method_counts into resource_sizes

resource_size.py now also reports method counts, so no need
to run method_counts.py separately.

BUG=609365

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0aba2c2011d7bf00bd42...
==========

[commit-bot: I haz the power, 2016-09-02 19:46:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/0aba2c2011d7bf00bd42...

[agrieve, 2016-09-02 20:30:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2309533002/ by agrieve@chromium.org.

The reason for reverting is: Broke cronet bot (and likely others too)..