Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: scripts/slave/recipe_modules/chromium_android/example.py

Issue 2238243003: Merge method_counts into resource_sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: split adding resource_sizes to perf bot into a separate change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_android/example.py
diff --git a/scripts/slave/recipe_modules/chromium_android/example.py b/scripts/slave/recipe_modules/chromium_android/example.py
index 19b2f3ce7879ade72cc5e26987854ac6348ad054..5e36fbd8ecfb9b8de5d5af187ce6b6b42888d639 100644
--- a/scripts/slave/recipe_modules/chromium_android/example.py
+++ b/scripts/slave/recipe_modules/chromium_android/example.py
@@ -57,10 +57,6 @@ BUILDERS = freeze({
'build': True,
'skip_wipe': True,
},
- 'java_method_count_builder': {
- 'build': True,
- 'java_method_count': True,
- },
'webview_tester': {
'remove_system_webview': True,
'disable_system_chrome': True,
@@ -156,10 +152,6 @@ def RunSteps(api, buildername):
'build_product.zip')
api.chromium_android.git_number()
- if config.get('java_method_count'):
- api.chromium_android.java_method_count(
- api.chromium.output_dir.join('chrome_public_apk', 'classes.dex.zip'))
-
if config.get('specific_install'):
api.chromium_android.adb_install_apk('Chrome.apk', devices=['abc123'])
@@ -234,13 +226,9 @@ def RunSteps(api, buildername):
if config.get('resource_size'):
api.chromium_android.resource_sizes(
- apk_path=api.chromium_android.apk_path('Chrome.apk'),
- so_path=api.path['checkout'].join(
- 'out', api.chromium.c.BUILD_CONFIG, 'chrome_apk', 'libs',
- 'armeabi-v7a', 'libchrome.so'),
- so_with_symbols_path=api.path['checkout'].join(
- 'out', api.chromium.c.BUILD_CONFIG, 'lib', 'libchrome.so'),
- chartjson_file=True)
+ apk_path=api.chromium_android.apk_path('Example.apk'),
+ chartjson_file=True,
+ upload_archives_to_bucket='Bucket')
if config.get('run_webview_cts'):
api.chromium_android.run_webview_cts(command_line_args=[

Powered by Google App Engine
This is Rietveld 408576698