scripts/slave/recipe_modules/chromium_tests/chromium_perf.py - Issue 2238243003: Merge method_counts into resource_sizes

Side by Side Diff: scripts/slave/recipe_modules/chromium_tests/chromium_perf.py

Issue 2238243003: Merge method_counts into resource_sizes (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« scripts/slave/recipe_modules/chromium_android/api.py ('K') | « scripts/slave/recipe_modules/chromium_android/example.expected/resource_size_builder_basic.json ('k') | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import collections	5 import collections

6	6

7 from . import steps	7 from . import steps

8	8

9	9

10 _builders = collections.defaultdict(dict)	10 _builders = collections.defaultdict(dict)

(...skipping 29 matching lines...) Expand all Loading...
40 spec['chromium_apply_config'] = ['android']	40 spec['chromium_apply_config'] = ['android']

41 spec['chromium_config_kwargs']['TARGET_ARCH'] = 'arm'	41 spec['chromium_config_kwargs']['TARGET_ARCH'] = 'arm'

42 spec['chromium_config_kwargs']['TARGET_PLATFORM'] = 'android'	42 spec['chromium_config_kwargs']['TARGET_PLATFORM'] = 'android'

43 spec['gclient_apply_config'] = ['android']	43 spec['gclient_apply_config'] = ['android']

44	44

45 return spec	45 return spec

46	46

47	47

48 def BuildSpec(config_name, perf_id, platform, target_bits):	48 def BuildSpec(config_name, perf_id, platform, target_bits):

49 if platform == 'android':	49 if platform == 'android':

50 # TODO: Run sizes on Android.	50 tests = [steps.ResourceSizesStep()]
	jbudorick 2016/08/15 15:37:43 I would prefer if you did this separately from the I would prefer if you did this separately from the method_count merge. agrieve 2016/09/02 18:23:18 Done. Show quoted text On 2016/08/15 15:37:43, jbudorick wrote: > I would prefer if you did this separately from the method_count merge. Done.
51 tests = []

52 else:	51 else:

53 tests = [steps.SizesStep('https://chromeperf.appspot.com', perf_id)]	52 tests = [steps.SizesStep('https://chromeperf.appspot.com', perf_id)]

54	53

55 spec = _BaseSpec(	54 spec = _BaseSpec(

56 bot_type='builder',	55 bot_type='builder',

57 config_name=config_name,	56 config_name=config_name,

58 disable_tests=True,	57 disable_tests=True,

59 platform=platform,	58 platform=platform,

60 target_bits=target_bits,	59 target_bits=target_bits,

61 tests=tests,	60 tests=tests,

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
162 _AddTestSpec('Mac 10.10 Perf', 'chromium-rel-mac10', 'mac',	161 _AddTestSpec('Mac 10.10 Perf', 'chromium-rel-mac10', 'mac',

163 num_host_shards=5)	162 num_host_shards=5)

164 _AddTestSpec('Mac Retina Perf', 'chromium-rel-mac-retina', 'mac',	163 _AddTestSpec('Mac Retina Perf', 'chromium-rel-mac-retina', 'mac',

165 num_host_shards=5)	164 num_host_shards=5)

166 _AddTestSpec('Mac HDD Perf', 'chromium-rel-mac-hdd', 'mac',	165 _AddTestSpec('Mac HDD Perf', 'chromium-rel-mac-hdd', 'mac',

167 num_host_shards=5)	166 num_host_shards=5)

168	167

169	168

170 _AddTestSpec('Linux Perf', 'linux-release', 'linux',	169 _AddTestSpec('Linux Perf', 'linux-release', 'linux',

171 num_host_shards=5)	170 num_host_shards=5)

OLD	NEW