LightingShader and NormalSource comment and style fixes

LightingShader and NormalSource comment and style fixes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237963002

Committed: https://skia.googlesource.com/skia/+/ee92063f9e1a28e301fe6cdc804dca0ccc837f67

[dvonbeck, 2016-08-11 18:14:02]

Description was changed from

==========
LightingShader and NormalSource comment and style fixes

BUG=skia:
==========

to

==========
LightingShader and NormalSource comment and style fixes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237963002
==========

[dvonbeck, 2016-08-11 18:14:29]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[egdaniel, 2016-08-11 20:21:02]

lgtm w/ one comment

https://codereview.chromium.org/2237963002/diff/1/src/core/SkNormalSource.h
File src/core/SkNormalSource.h (right):

https://codereview.chromium.org/2237963002/diff/1/src/core/SkNormalSource.h#n...
src/core/SkNormalSource.h:112: works only for shapes whose geometry processors
implement distance vectors (as of 2016-08-11
After the first sentence, I would say "Currently this is not implemented on CPU
rendering. On GPU this currently only works for anti-aliased circles and
rectangles." At this level of the code there isn't a need to go into what
geometry processors are.

[dvonbeck, 2016-08-11 20:44:54]

The CQ bit was checked by dvonbeck@google.com

[dvonbeck, 2016-08-11 20:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/2237963002/#ps20001
(title: "Addressed patch 1 comment")

[commit-bot: I haz the power, 2016-08-11 20:44:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:18:01]

Description was changed from

==========
LightingShader and NormalSource comment and style fixes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237963002
==========

to

==========
LightingShader and NormalSource comment and style fixes

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237963002

Committed:
https://skia.googlesource.com/skia/+/ee92063f9e1a28e301fe6cdc804dca0ccc837f67
==========

[commit-bot: I haz the power, 2016-08-11 21:18:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ee92063f9e1a28e301fe6cdc804dca0ccc837f67