LightingShader and NormalSource comment and style fixes

src/core/SkNormalBevelSource.cpp

 /*
  * Copyright 2016 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkNormalBevelSource.h"
 
 #include "SkNormalSource.h"
@@ skipping 227 matching lines @@
     }
 
     SkNormalSource::BevelType fBevelType;
     SkScalar fBevelWidth;
     SkScalar fBevelHeight;
 };
 
 sk_sp<GrFragmentProcessor> SkNormalBevelSourceImpl::asFragmentProcessor(
         const SkShader::AsFPArgs& args) const {
 
+    // This assumes a uniform scale. Anisotropic scaling might not be handled gracefully.
     SkScalar maxScale = args.fViewMatrix->getMaxScale();
 
     // Providing device-space width and height
     return sk_make_sp<NormalBevelFP>(fType, maxScale * fWidth, maxScale * fHeight);
 }
 
 #endif // SK_SUPPORT_GPU
 
 ////////////////////////////////////////////////////////////////////////////
 
 SkNormalBevelSourceImpl::Provider::Provider() {}
 
 SkNormalBevelSourceImpl::Provider::~Provider() {}
 
 SkNormalSource::Provider* SkNormalBevelSourceImpl::asProvider(const SkShader::ContextRec &rec,
-                                                            void *storage) const {
+                                                              void *storage) const {
     return new (storage) Provider();
 }
 
 size_t SkNormalBevelSourceImpl::providerSize(const SkShader::ContextRec&) const {
     return sizeof(Provider);
 }
 
+// TODO Implement feature for the CPU pipeline
 void SkNormalBevelSourceImpl::Provider::fillScanLine(int x, int y, SkPoint3 output[],
-                                                   int count) const {
+                                                     int count) const {
     for (int i = 0; i < count; i++) {
         output[i] = {0.0f, 0.0f, 1.0f};
     }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 sk_sp<SkFlattenable> SkNormalBevelSourceImpl::CreateProc(SkReadBuffer& buf) {
 
     auto type = static_cast<SkNormalSource::BevelType>(buf.readInt());
     SkScalar width = buf.readScalar();
     SkScalar height = buf.readScalar();
 
     return sk_make_sp<SkNormalBevelSourceImpl>(type, width, height);
 }
 
 void SkNormalBevelSourceImpl::flatten(SkWriteBuffer& buf) const {
     this->INHERITED::flatten(buf);
 
     buf.writeInt(static_cast<int>(fType));
     buf.writeScalar(fWidth);
     buf.writeScalar(fHeight);
 }
 
 ////////////////////////////////////////////////////////////////////////////
 
 sk_sp<SkNormalSource> SkNormalSource::MakeBevel(BevelType type, SkScalar width, SkScalar height) {
-    /* TODO make sure this checks are tolerant enough to account for loss of conversion when GPUs
+    /* TODO make sure these checks are tolerant enough to account for loss of conversion when GPUs
        use 16-bit float types. We don't want to assume stuff is non-zero on the GPU and be wrong.*/
     SkASSERT(width > 0.0f && !SkScalarNearlyZero(width));
     if (SkScalarNearlyZero(height)) {
         return SkNormalSource::MakeFlat();
     }
 
     return sk_make_sp<SkNormalBevelSourceImpl>(type, width, height);
 }