GN: fail gracefully when git commit info cannot be extracted

GN: fail gracefully when git commit info cannot be extracted

See https://groups.google.com/a/chromium.org/d/msg/gn-dev/7nlJv486bD4/V9ZsfV_nBAAJ
for context.

BUG=551343
R=dpranke@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/e9fcf209818dede2348c41913994b5d9ea81314c

[Paweł Hajdan Jr., 2016-08-11 17:24:37]

phajdan.jr@chromium.org changed reviewers:
+ dpranke@chromium.org

[Paweł Hajdan Jr., 2016-08-11 17:24:41]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 17:25:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:57:22]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-12 23:18:56]

dpranke@chromium.org changed reviewers:
+ brettw@chromium.org

[Dirk Pranke, 2016-08-12 23:18:56]

I think this is probably fine (i.e., LGTM), but cc'ing brettw@ as well in case
he wants to weigh in. I don't think you need to wait for his approval, though.

[brettw, 2016-08-15 16:41:57]

This is fine but then we should fix gn_main.cc to remove the conditional
includes and then maybe we can also remove the GN_BUILD define.

[Paweł Hajdan Jr., 2016-08-16 11:09:59]

On 2016/08/15 at 16:41:57, brettw wrote:
> This is fine but then we should fix gn_main.cc to remove the conditional
includes and then maybe we can also remove the GN_BUILD define.

I consider above somewhat orthogonal.

gn_main.cc can be changed when GN bootstrap is aware of last_commit_position.py
.

[Paweł Hajdan Jr., 2016-08-16 11:10:10]

phajdan.jr@chromium.org changed reviewers:
+ phajdan@google.com

[commit-bot: I haz the power, 2016-08-16 11:22:16]

Description was changed from

==========
GN: fail gracefully when git commit info cannot be extracted

See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/7nlJv486bD4/V9ZsfV_nBAAJ
for context.

BUG=551343
==========

to

==========
GN: fail gracefully when git commit info cannot be extracted

See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/7nlJv486bD4/V9ZsfV_nBAAJ
for context.

BUG=551343
R=dpranke@chromium.org

Committed: https://crrev.com/e9fcf209818dede2348c41913994b5d9ea81314c
Cr-Commit-Position: refs/heads/master@{#412213}
==========

[commit-bot: I haz the power, 2016-08-16 11:22:17]

Patchset 1 (id:??) landed as
https://crrev.com/e9fcf209818dede2348c41913994b5d9ea81314c
Cr-Commit-Position: refs/heads/master@{#412213}

[Paweł Hajdan Jr., 2016-08-16 11:23:43]

Description was changed from

==========
GN: fail gracefully when git commit info cannot be extracted

See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/7nlJv486bD4/V9ZsfV_nBAAJ
for context.

BUG=551343
R=dpranke@chromium.org

Committed: https://crrev.com/e9fcf209818dede2348c41913994b5d9ea81314c
Cr-Commit-Position: refs/heads/master@{#412213}
==========

to

==========
GN: fail gracefully when git commit info cannot be extracted

See
https://groups.google.com/a/chromium.org/d/msg/gn-dev/7nlJv486bD4/V9ZsfV_nBAAJ
for context.

BUG=551343
R=dpranke@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/e9fcf209818dede2348c41913994...
==========

[Paweł Hajdan Jr., 2016-08-16 11:23:44]

Committed patchset #1 (id:1) manually as
e9fcf209818dede2348c41913994b5d9ea81314c (presubmit successful).