tools/gn/last_commit_position.py - Issue 2237913002: GN: fail gracefully when git commit info cannot be extracted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/last_commit_position.py

Issue 2237913002: GN: fail gracefully when git commit info cannot be extracted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/last_commit_position.py

diff --git a/tools/gn/last_commit_position.py b/tools/gn/last_commit_position.py

index b710ed0b80897edfef31328a95d432556f450737..a91f7226e17ec7693e8d086abfc48eab4452f729 100644

--- a/tools/gn/last_commit_position.py

+++ b/tools/gn/last_commit_position.py

@@ -95,7 +95,6 @@ header_guard = sys.argv[3]

value = FetchCommitPosition(git_directory)

if not value:

- print "Could not get last commit position."

- sys.exit(1)

+ value = 'UNKNOWN'

WriteHeader(output_file, header_guard, value)

« no previous file with comments | « no previous file | no next file » | no next file with comments »