mash: Migrate some misc ShelfLayoutManager deps to ash common.

mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd
Cr-Commit-Position: refs/heads/master@{#411238}

[msw, 2016-08-11 00:18:31]

Description was changed from

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

BUG=615155
==========

to

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Move kCrossFadeDurationMS to ash/common.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

[msw, 2016-08-11 00:18:31]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-11 00:26:18]

Patchset #2 (id:20001) has been deleted

[msw, 2016-08-11 00:26:34]

Hey James, please take a look; thanks!

[msw, 2016-08-11 00:26:47]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 00:27:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-11 00:50:07]

LGTM with an optional thought.

https://codereview.chromium.org/2237613002/diff/40001/ash/aura/wm_shelf_aura.h
File ash/aura/wm_shelf_aura.h (right):

https://codereview.chromium.org/2237613002/diff/40001/ash/aura/wm_shelf_aura....
ash/aura/wm_shelf_aura.h:92: std::unique_ptr<ShelfBezelEventHandler>
bezel_event_handler_;
Can you file a bug for coming up with a mus-compatible way to deal with bezel
events? It seems like something easy to forget. No need to reference the bug
here.

https://codereview.chromium.org/2237613002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (left):

https://codereview.chromium.org/2237613002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:30: #include "ash/shell.h"
hooray!

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animations.h
File ash/wm/window_animations.h (left):

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animation...
ash/wm/window_animations.h:36: extern const int kCrossFadeDurationMS;
WDYT of leaving this where it is, and introducing a new kShelfFadeDuration
constant in ShelfLayoutManager? There's no particular reason that the shelf
animation timing needs to match other animation timing. Also, this constant is
strongly related to the functions in this file.

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animations.h
File ash/wm/window_animations.h (right):

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animation...
ash/wm/window_animations.h:22: namespace views {}
Wow, I've never seen this before.

[msw, 2016-08-11 02:05:35]

Description was changed from

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Move kCrossFadeDurationMS to ash/common.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

[msw, 2016-08-11 02:08:40]

Patchset #3 (id:60001) has been deleted

[msw, 2016-08-11 02:08:51]

https://codereview.chromium.org/2237613002/diff/40001/ash/aura/wm_shelf_aura.h
File ash/aura/wm_shelf_aura.h (right):

https://codereview.chromium.org/2237613002/diff/40001/ash/aura/wm_shelf_aura....
ash/aura/wm_shelf_aura.h:92: std::unique_ptr<ShelfBezelEventHandler>
bezel_event_handler_;
On 2016/08/11 00:50:06, James Cook wrote:
> Can you file a bug for coming up with a mus-compatible way to deal with bezel
> events? It seems like something easy to forget. No need to reference the bug
> here.

Done; referenced it here anyway; similar above.

https://codereview.chromium.org/2237613002/diff/40001/ash/shelf/shelf_layout_...
File ash/shelf/shelf_layout_manager.cc (left):

https://codereview.chromium.org/2237613002/diff/40001/ash/shelf/shelf_layout_...
ash/shelf/shelf_layout_manager.cc:30: #include "ash/shell.h"
On 2016/08/11 00:50:06, James Cook wrote:
> hooray!

Acknowledged.

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animations.h
File ash/wm/window_animations.h (left):

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animation...
ash/wm/window_animations.h:36: extern const int kCrossFadeDurationMS;
On 2016/08/11 00:50:06, James Cook wrote:
> WDYT of leaving this where it is, and introducing a new kShelfFadeDuration
> constant in ShelfLayoutManager? There's no particular reason that the shelf
> animation timing needs to match other animation timing. Also, this constant is
> strongly related to the functions in this file.

Done.

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animations.h
File ash/wm/window_animations.h (right):

https://codereview.chromium.org/2237613002/diff/40001/ash/wm/window_animation...
ash/wm/window_animations.h:22: namespace views {}
On 2016/08/11 00:50:06, James Cook wrote:
> Wow, I've never seen this before.

Removed.

[msw, 2016-08-11 02:08:55]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-11 02:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2237613002/#ps80001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-11 02:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:57:56]

Description was changed from

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

[commit-bot: I haz the power, 2016-08-11 02:57:57]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-11 03:00:52]

Description was changed from

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate some misc ShelfLayoutManager deps to ash common.

Nix in_mus()-specific code in ShelfLayoutManager.
Move ShelfBezelEventHandler to WmShelfAura & use WmShelf.
Define a separate shelf show/hide animation duration constant.

BUG=615155
TEST=Automated; no cros regressions.
R=jamescook@chromium.org

Committed: https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd
Cr-Commit-Position: refs/heads/master@{#411238}
==========

[commit-bot: I haz the power, 2016-08-11 03:00:53]

Patchset 3 (id:??) landed as
https://crrev.com/83d3bfb776904539c12d7cbf0644b0ba596378fd
Cr-Commit-Position: refs/heads/master@{#411238}