mash: Migrate some misc ShelfLayoutManager deps to ash common.

ash/wm/window_animations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_ANIMATIONS_H_
 #define ASH_WM_WINDOW_ANIMATIONS_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
 #include "ui/gfx/animation/tween.h"
 #include "ui/gfx/transform.h"
 #include "ui/wm/core/window_animations.h"
 
 namespace aura {
 class Window;
 }
 namespace ui {
 class Layer;
 class LayerTreeOwner;
 }
 namespace views {}

[James Cook, 2016/08/11 00:50:06]

Wow, I've never seen this before.

[msw, 2016/08/11 02:08:51]

Removed.

 
 // This is only for animations specific to Ash. For window animations shared
 // with desktop Chrome, see ui/views/corewm/window_animations.h.
 namespace ash {
 
 // Direction for ash-specific window animations used in workspaces and
 // lock/unlock animations.
 enum LayerScaleAnimationDirection {
   LAYER_SCALE_ANIMATION_ABOVE,
   LAYER_SCALE_ANIMATION_BELOW,
 };
 
-// Amount of time for the cross fade animation.
-extern const int kCrossFadeDurationMS;

[James Cook, 2016/08/11 00:50:06]

WDYT of leaving this where it is, and introducing a new kShelfFadeDuration
constant in ShelfLayoutManager? There's no particular reason that the shelf
animation timing needs to match other animation timing. Also, this constant is
strongly related to the functions in this file.

[msw, 2016/08/11 02:08:51]

Done.

-
 // Implementation of cross fading. Window is the window being cross faded. It
 // should be at the target bounds. |old_layer_owner| contains the previous layer
 // from |window|.  |tween_type| specifies the tween type of the cross fade
 // animation.
 ASH_EXPORT base::TimeDelta CrossFadeAnimation(
     aura::Window* window,
     std::unique_ptr<ui::LayerTreeOwner> old_layer_owner,
     gfx::Tween::Type tween_type);
 
 ASH_EXPORT bool AnimateOnChildWindowVisibilityChanged(aura::Window* window,
@@ skipping 13 matching lines @@
 
 // Returns the approximate bounds to which |window| will be animated when it
 // is minimized. The bounds are approximate because the minimize animation
 // involves rotation.
 ASH_EXPORT gfx::Rect GetMinimizeAnimationTargetBoundsInScreen(
     aura::Window* window);
 
 }  // namespace ash
 
 #endif  // ASH_WM_WINDOW_ANIMATIONS_H_