Cronet/QUIC - Added histograms to measure the time spent to seriliaze

components/cronet/android/cronet_url_request_context_adapter.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/android/cronet_url_request_context_adapter.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <utility>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_file.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
+#include "base/metrics/histogram_macros.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/single_thread_task_runner.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "components/cronet/android/cert/cert_verifier_cache_serializer.h"
 #include "components/cronet/android/cert/proto/cert_verification.pb.h"
 #include "components/cronet/histogram_manager.h"
 #include "components/cronet/url_request_context_config.h"
 #include "components/prefs/pref_change_registrar.h"
 #include "components/prefs/pref_filter.h"
@@ skipping 624 matching lines @@
           net::AlternateProtocol::QUIC, "",
           static_cast<uint16_t>(quic_hint.alternate_port));
       context_->http_server_properties()->SetAlternativeService(
           quic_server, alternative_service, base::Time::Max());
     }
   }
 
   // If there is a cert_verifier, then populate its cache with
   // |cert_verifier_data|.
   if (!config->cert_verifier_data.empty() && context_->cert_verifier()) {
+    base::TimeTicks start_time(base::TimeTicks::Now());
     std::string data;
     cronet_pb::CertVerificationCache cert_verification_cache;
     if (base::Base64Decode(config->cert_verifier_data, &data) &&
         cert_verification_cache.ParseFromString(data)) {
       DeserializeCertVerifierCache(cert_verification_cache,
                                    reinterpret_cast<net::CachingCertVerifier*>(
                                        context_->cert_verifier()));
     }
+    UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.DeserializeTime",
+                        base::TimeTicks::Now() - start_time);
   }
 
   // Iterate through PKP configuration for every host.
   for (const auto& pkp : config->pkp_list) {
     // Add the host pinning.
     context_->transport_security_state()->AddHPKP(
         pkp->host, pkp->expiration_date, pkp->include_subdomains,
         pkp->pin_hashes, GURL::EmptyGURL());
   }
 
@@ skipping 106 matching lines @@
       FROM_HERE,
       base::Bind(
           &CronetURLRequestContextAdapter::GetCertVerifierDataOnNetworkThread,
           base::Unretained(this)));
 }
 
 void CronetURLRequestContextAdapter::GetCertVerifierDataOnNetworkThread() {
   DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread());
   std::string encoded_data;
   if (is_context_initialized_ && context_->cert_verifier()) {
+    base::TimeTicks start_time(base::TimeTicks::Now());
     std::string data;
     cronet_pb::CertVerificationCache cert_cache =
         SerializeCertVerifierCache(*reinterpret_cast<net::CachingCertVerifier*>(
             context_->cert_verifier()));
     cert_cache.SerializeToString(&data);
     base::Base64Encode(data, &encoded_data);
+    UMA_HISTOGRAM_TIMES("Net.Cronet.CertVerifierCache.SerializeTime",

[rkaplow, 2016/08/11 17:14:23]

you can simplify this using a SCOPED_UMA_HISTOGRAM_TIMER

[ramant (doing other things), 2016/08/11 17:21:15]

Done.

+                        base::TimeTicks::Now() - start_time);
   }
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_CronetUrlRequestContext_onGetCertVerifierData(
       env, jcronet_url_request_context_.obj(),
       base::android::ConvertUTF8ToJavaString(env, encoded_data).obj());
 }
 
 base::Thread* CronetURLRequestContextAdapter::GetFileThread() {
   DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread());
   if (!file_thread_) {
@@ skipping 159 matching lines @@
     JNIEnv* env,
     const JavaParamRef<jclass>& jcaller) {
   base::StatisticsRecorder::Initialize();
   std::vector<uint8_t> data;
   if (!HistogramManager::GetInstance()->GetDeltas(&data))
     return ScopedJavaLocalRef<jbyteArray>();
   return base::android::ToJavaByteArray(env, &data[0], data.size());
 }
 
 }  // namespace cronet