Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Use IsPropertyName in VisitObjectLiteral to decide whether to do
a named property store or call SetProperty.

BUG=v8:5203
Committed: https://crrev.com/51e9d5ad2a75a08fc9d9349d35718f50ef099bb3
Cr-Commit-Position: refs/heads/master@{#38577}

[rmcilroy, 2016-08-10 21:27:30]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:27:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 21:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:51:28]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-08-11 07:48:36]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, verwaest@chromium.org

[rmcilroy, 2016-08-11 07:48:37]

Toon / Benedikt, I believe IsProperyName gives the same result as
IsInternalizedString in this situation, and is clearer, but let me know if I'm
missing something. PTAL, thanks.

[Toon Verwaest, 2016-08-11 08:40:12]

This will force a runtime call for {["1"]:...} whereas the keyed store IC could
convert "1" to 1 inline and store, right?
I guess that's fine for now though since it doesn't seem like an important
usecase, and elements should probably be supported uniformly anyway.

lgtm

[rmcilroy, 2016-08-11 09:07:21]

On 2016/08/11 08:40:12, Toon Verwaest wrote:
> This will force a runtime call for {["1"]:...} whereas the keyed store IC
could
> convert "1" to 1 inline and store, right?

I think this was already forced to be a runtime call. This is a computed
property name, so it doesn't get dealt with at this point, instead they get
dealt with below by calling Runtime::DefineDataPropertyInLiteral.

> I guess that's fine for now though since it doesn't seem like an important
> usecase, and elements should probably be supported uniformly anyway.
> 
> lgtm

[Benedikt Meurer, 2016-08-11 12:40:46]

lgtm

[rmcilroy, 2016-08-11 12:50:27]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-08-11 12:50:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 12:52:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-11 12:52:42]

Description was changed from

==========
Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Use IsPropertyName in VisitObjectLiteral to decide whether to do
a named property store or call SetProperty.

BUG=v8:5203
==========

to

==========
Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Use IsPropertyName in VisitObjectLiteral to decide whether to do
a named property store or call SetProperty.

BUG=v8:5203

Committed: https://crrev.com/51e9d5ad2a75a08fc9d9349d35718f50ef099bb3
Cr-Commit-Position: refs/heads/master@{#38577}
==========

[commit-bot: I haz the power, 2016-08-11 12:52:43]

Patchset 1 (id:??) landed as
https://crrev.com/51e9d5ad2a75a08fc9d9349d35718f50ef099bb3
Cr-Commit-Position: refs/heads/master@{#38577}