src/full-codegen/arm/full-codegen-arm.cc - Issue 2237553004: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2237553004: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index 4c18a87f2e2569684fa2e5a1a98ee54c4c223dd5..aeb869ea94e05ee72d52245dabeb993eaca52959 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1428,7 +1428,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

case ObjectLiteral::Property::COMPUTED:

// It is safe to use [[Put]] here because the boilerplate already

// contains computed properties with an uninitialized value.

- if (key->value()->IsInternalizedString()) {

+ if (key->IsPropertyName()) {

if (property->emit_store()) {

VisitForAccumulatorValue(value);

DCHECK(StoreDescriptor::ValueRegister().is(r0));

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »