src/core/SkCanvas.cpp - Issue 2237493002: Added PointLights to SkLights::Light

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 2237493002: Added PointLights to SkLights::Light (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: changed a vec3 to a point3 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index 63611443e6cc24991f5591d07424832e508a9df3..0ded37fe1804a9c1121c436dffe3e4b8b8866365 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -3132,8 +3132,8 @@ void SkCanvas::onDrawShadowedPicture(const SkPicture* picture,

// povDepthMap

{

SkLights::Builder builder;

- builder.add(SkLights::Light(SkColor3f::Make(1.0f, 1.0f, 1.0f),

- SkVector3::Make(0.0f, 0.0f, 1.0f)));

+ builder.add(SkLights::Light::MakeDirectional(SkColor3f::Make(1.0f, 1.0f, 1.0f),

+ SkVector3::Make(0.0f, 0.0f, 1.0f)));

sk_sp<SkLights> povLight = builder.finish();

SkImageInfo info = SkImageInfo::Make(picture->cullRect().width(),