Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: third_party/WebKit/public/platform/WebLayerTreeView.h

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove offset/scale params, rename commands, clip by backing size. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebLayerTreeView.h
diff --git a/third_party/WebKit/public/platform/WebLayerTreeView.h b/third_party/WebKit/public/platform/WebLayerTreeView.h
index 48f41ae8b578cc28a5ad58c673cb227f46c5d00a..ac39059c688142f82f7129d026cc0455cac5ebc1 100644
--- a/third_party/WebKit/public/platform/WebLayerTreeView.h
+++ b/third_party/WebKit/public/platform/WebLayerTreeView.h
@@ -67,8 +67,10 @@ public:
// View properties ---------------------------------------------------
virtual void setViewportSize(const WebSize& deviceViewportSize) { }
+ virtual WebSize getViewportSize() const { return WebSize(); }
chrishtr 2016/08/22 22:00:42 In what coordinate space? Not including the device
Eric Seckler 2016/08/23 09:32:19 It's in physical pixels. Added a comment.
virtual void setDeviceScaleFactor(float) { }
+ virtual float getDeviceScaleFactor() const { return 1.f; }
dgozman 2016/08/22 22:22:06 Having both set and get here looks strange. AFAIU,
Eric Seckler 2016/08/23 09:32:19 True, except that there could be a device_scale_fa
// Sets the background color for the viewport.
virtual void setBackgroundColor(WebColor) { }

Powered by Google App Engine
This is Rietveld 408576698