content/renderer/devtools/render_widget_screen_metrics_emulator.cc - Issue 2237433004: Adds DevTools commands for forced viewport override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/render_widget_screen_metrics_emulator.cc

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove offset/scale params, rename commands, clip by backing size. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/emulation_handler.cc ('k') | content/renderer/gpu/render_widget_compositor.h » ('j') | third_party/WebKit/Source/core/frame/FrameView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/render_widget_screen_metrics_emulator.cc

diff --git a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

index 6c27f46570fe8912622ec1d850abaa1db971bd0b..a894b07b037ef63614aea6f2b4c084000f2faae6 100644

--- a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

+++ b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc

@@ -66,14 +66,6 @@ void RenderWidgetScreenMetricsEmulator::Apply() {

offset_.set_y(

(original_size().height() - scale_ * applied_widget_rect_.height()) /

2);

- } else {

- scale_ = emulation_params_.scale;

- offset_.SetPoint(emulation_params_.offset.x, emulation_params_.offset.y);

- if (!emulation_params_.viewSize.width &&

- !emulation_params_.viewSize.height && scale_) {

- applied_widget_rect_.set_size(

- gfx::ScaleToRoundedSize(original_size(), 1.f / scale_));

- }

}

gfx::Rect window_screen_rect;