Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2237433004: Adds DevTools commands for forced viewport override. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove offset/scale params, rename commands, clip by backing size. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index 8c49dc36344679d0e98243295936aad2357daca9..5ee16845049854a1d7b49acc6268d266e3aadf8f 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -191,6 +191,7 @@ public:
void setInputEventsTransformForEmulation(const IntSize&, float);
void setScrollPosition(const DoublePoint&, ScrollType, ScrollBehavior = ScrollBehaviorInstant) override;
+ void didChangeScrollOffset();
void didUpdateElasticOverscroll();
@@ -450,6 +451,11 @@ public:
IntRect visibleContentRect(IncludeScrollbarsInRect = ExcludeScrollbars) const override;
IntSize visibleContentSize(IncludeScrollbarsInRect = ExcludeScrollbars) const;
+ // Clips the provided rect to the visible content area. For this purpose, we
+ // also query the chrome client for any active overrides to the visible area
+ // (e.g. DevTool's viewport override).
+ void clipPaintRect(FloatRect*) const;
chrishtr 2016/08/22 22:00:42 Why provide a clipPaintRect method instead of just
Eric Seckler 2016/08/23 09:32:18 Actually, because I was thinking we could move the
+
// Functions for getting/setting the size of the document contained inside the FrameView (as an IntSize or as individual width and height
// values).
IntSize contentsSize() const override; // Always at least as big as the visibleWidth()/visibleHeight().
@@ -878,6 +884,7 @@ private:
DoubleSize m_pendingScrollDelta;
DoublePoint m_scrollPosition;
IntSize m_contentsSize;
+ WTF::Optional<IntRect> m_visibleContentRectForPainting;
int m_scrollbarsAvoidingResizer;
bool m_scrollbarsSuppressed;

Powered by Google App Engine
This is Rietveld 408576698