[debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.

[debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.

R=mstarzinger@chromium.org
BUG=v8:5265
Committed: https://crrev.com/e9b4d57eff8af0f63eb4ce368b6b46c840309a42
Cr-Commit-Position: refs/heads/master@{#38602}

[Yang, 2016-08-12 08:04:12]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 08:04:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:04:26]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Yang, 2016-08-12 08:05:34]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 08:05:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-08-12 08:27:23]

LGTM.

https://codereview.chromium.org/2237423002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2237423002/diff/1/src/objects-inl.h#newcode6176
src/objects-inl.h:6176: return HasBytecodeArray();
Just for my own confirmation, this should be the same as the following
predicate, correct?

return (HasBaselineCode() && code()->has_debug_break_slots()) ||
       (!HasBaselineCode() && HasBytecodeArray());

I am fine expressing it either way. Just wanted to confirm my own intuition of
things.

[Yang, 2016-08-12 08:31:27]

https://codereview.chromium.org/2237423002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/2237423002/diff/1/src/objects-inl.h#newcode6176
src/objects-inl.h:6176: return HasBytecodeArray();
On 2016/08/12 08:27:23, Michael Starzinger wrote:
> Just for my own confirmation, this should be the same as the following
> predicate, correct?
> 
> return (HasBaselineCode() && code()->has_debug_break_slots()) ||
>        (!HasBaselineCode() && HasBytecodeArray());
> 
> I am fine expressing it either way. Just wanted to confirm my own intuition of
> things.

Yes. What it says is: if we have fcg code, it needs to have been recompiled for
debugging; if we don't, we need to have bytecode to work with.

[commit-bot: I haz the power, 2016-08-12 08:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:42:37]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-08-12 08:53:11]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:53:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 08:54:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 08:55:13]

Description was changed from

==========
[debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.

R=mstarzinger@chromium.org
BUG=v8:5265
==========

to

==========
[debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.

R=mstarzinger@chromium.org
BUG=v8:5265

Committed: https://crrev.com/e9b4d57eff8af0f63eb4ce368b6b46c840309a42
Cr-Commit-Position: refs/heads/master@{#38602}
==========

[commit-bot: I haz the power, 2016-08-12 08:55:14]

Patchset 1 (id:??) landed as
https://crrev.com/e9b4d57eff8af0f63eb4ce368b6b46c840309a42
Cr-Commit-Position: refs/heads/master@{#38602}