src/compiler.cc - Issue 2237423002: [debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 2237423002: [debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 393e30a95747afa87febdd1979ca78cdbf0a0185..7f5c5975a841fb17a68fff6579a62ac3c861e027 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -526,8 +526,6 @@ void InstallSharedCompilationResult(CompilationInfo* info,

if (info->is_debug() && info->has_bytecode_array()) {

shared->ClearBytecodeArray();

}

- // Assert that we are not overwriting (possibly patched) debug code.

- DCHECK(!shared->HasDebugInfo());

DCHECK(!info->code().is_null());

shared->ReplaceCode(*info->code());

if (info->has_bytecode_array()) {

« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/objects-inl.h » ('J')