Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2240103002: [debug] make sure switching to debug fcg code works. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@prepareforbreak
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] make sure switching to debug fcg code works. R=mstarzinger@chromium.org BUG=v8:5265 Committed: https://crrev.com/8b82e0d725151e3a6e85dd8bb22a88060f3431c7 Cr-Commit-Position: refs/heads/master@{#38607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Yang
4 years, 4 months ago (2016-08-12 08:56:04 UTC) #1
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-12 09:45:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240103002/1
4 years, 4 months ago (2016-08-12 10:24:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 11:05:47 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 11:06:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b82e0d725151e3a6e85dd8bb22a88060f3431c7
Cr-Commit-Position: refs/heads/master@{#38607}

Powered by Google App Engine
This is Rietveld 408576698