Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2236703002: [Extensions] Convert some SyncExtensionFunctions (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
dmazzoni, lazyboy
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some SyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove SyncExtensionFunctions from: - info_private_api - wallpaper_private_api - command_line_private_api - tts_engine_extension_api - app_current_window_internal_api - audio_api BUG=634140 Committed: https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98 Cr-Commit-Position: refs/heads/master@{#412930}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : cros #

Patch Set 4 : nulltpr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -172 lines) Patch
M chrome/browser/chromeos/extensions/info_private_api.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 1 2 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/command_line_private/command_line_private_api.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.h View 1 2 3 16 chunks +23 lines, -19 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 2 3 8 chunks +84 lines, -85 lines 0 comments Download
M extensions/browser/api/audio/audio_api.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M extensions/browser/api/audio/audio_api.cc View 1 3 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Devlin
4 years, 4 months ago (2016-08-15 19:23:00 UTC) #7
lazyboy
lgtm.
4 years, 4 months ago (2016-08-15 21:09:40 UTC) #8
Devlin
+dmazzoni@ for c/b/speech/extension_api
4 years, 4 months ago (2016-08-15 22:24:49 UTC) #10
dmazzoni
lgtm I'm assuming this is running on the same thread it was running before, right? ...
4 years, 4 months ago (2016-08-18 17:21:26 UTC) #11
Devlin
On 2016/08/18 17:21:26, dmazzoni wrote: > lgtm > > I'm assuming this is running on ...
4 years, 4 months ago (2016-08-18 17:23:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236703002/60001
4 years, 4 months ago (2016-08-18 17:24:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/220886)
4 years, 4 months ago (2016-08-18 18:13:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2236703002/60001
4 years, 4 months ago (2016-08-18 19:41:26 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-18 21:21:59 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:24:23 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d4f86d207a9b2f7644d74f4509369611eee41a98
Cr-Commit-Position: refs/heads/master@{#412930}

Powered by Google App Engine
This is Rietveld 408576698