Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3080)

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.cc

Issue 2236703002: [Extensions] Convert some SyncExtensionFunctions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nulltpr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/info_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/info_private_api.cc b/chrome/browser/chromeos/extensions/info_private_api.cc
index 9ff2843b4a2dddcf1e3aadef4b439c165ac12738..36350e709e3bdc43a2766d89766793032f56ec6f 100644
--- a/chrome/browser/chromeos/extensions/info_private_api.cc
+++ b/chrome/browser/chromeos/extensions/info_private_api.cc
@@ -238,7 +238,7 @@ ChromeosInfoPrivateSetFunction::ChromeosInfoPrivateSetFunction() {
ChromeosInfoPrivateSetFunction::~ChromeosInfoPrivateSetFunction() {
}
-bool ChromeosInfoPrivateSetFunction::RunSync() {
+ExtensionFunction::ResponseAction ChromeosInfoPrivateSetFunction::Run() {
std::string param_name;
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &param_name));
if (param_name == kPropertyTimezone) {
@@ -255,12 +255,11 @@ bool ChromeosInfoPrivateSetFunction::RunSync() {
pref_name,
param_value);
} else {
- error_ = ErrorUtils::FormatErrorMessage(kPropertyNotFound, param_name);
- return false;
+ return RespondNow(Error(kPropertyNotFound, param_name));
}
}
- return true;
+ return RespondNow(NoArguments());
}
} // namespace extensions
« no previous file with comments | « chrome/browser/chromeos/extensions/info_private_api.h ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698