Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_private_api.cc

Issue 2236703002: [Extensions] Convert some SyncExtensionFunctions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nulltpr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/wallpaper_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
index 6bbde190be7cb1029ce078efebb829dcb378debb..f339e3cf085391d6588d6d35f631a26ba430556e 100644
--- a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
+++ b/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
@@ -305,7 +305,7 @@ user_manager::User::WallpaperType getWallpaperType(
} // namespace
-bool WallpaperPrivateGetStringsFunction::RunSync() {
+ExtensionFunction::ResponseAction WallpaperPrivateGetStringsFunction::Run() {
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
#define SET_STRING(id, idr) \
@@ -361,19 +361,18 @@ bool WallpaperPrivateGetStringsFunction::RunSync() {
dict->SetString("canceledWallpaper",
wallpaper_api_util::kCancelWallpaperMessage);
- SetResult(std::move(dict));
- return true;
+ return RespondNow(OneArgument(std::move(dict)));
}
-bool WallpaperPrivateGetSyncSettingFunction::RunSync() {
+ExtensionFunction::ResponseAction
+WallpaperPrivateGetSyncSettingFunction::Run() {
Profile* profile = Profile::FromBrowserContext(browser_context());
ProfileSyncService* sync =
ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile);
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetBoolean("syncThemes",
sync->GetActiveDataTypes().Has(syncer::THEMES));
- SetResult(std::move(dict));
- return true;
+ return RespondNow(OneArgument(std::move(dict)));
}
WallpaperPrivateSetWallpaperIfExistsFunction::
@@ -971,7 +970,8 @@ void WallpaperPrivateGetOfflineWallpaperListFunction::OnComplete(
SendResponse(true);
}
-bool WallpaperPrivateRecordWallpaperUMAFunction::RunSync() {
+ExtensionFunction::ResponseAction
+WallpaperPrivateRecordWallpaperUMAFunction::Run() {
std::unique_ptr<record_wallpaper_uma::Params> params(
record_wallpaper_uma::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params);
@@ -979,5 +979,5 @@ bool WallpaperPrivateRecordWallpaperUMAFunction::RunSync() {
user_manager::User::WallpaperType source = getWallpaperType(params->source);
UMA_HISTOGRAM_ENUMERATION("Ash.Wallpaper.Source", source,
user_manager::User::WALLPAPER_TYPE_COUNT);
- return true;
+ return RespondNow(NoArguments());
}

Powered by Google App Engine
This is Rietveld 408576698