Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: telemetry/telemetry/internal/browser/browser_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Add stack traces and more logging Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/browser_unittest.py
diff --git a/telemetry/telemetry/internal/browser/browser_unittest.py b/telemetry/telemetry/internal/browser/browser_unittest.py
index 9c9b3edbb13a2ecfae8c88069522c496ae4a9fd9..a12c6c5769ea82aa219580727c1f4e187d2f2dcf 100644
--- a/telemetry/telemetry/internal/browser/browser_unittest.py
+++ b/telemetry/telemetry/internal/browser/browser_unittest.py
@@ -49,6 +49,8 @@ class BrowserTest(browser_test_case.BrowserTestCase):
self.assertEquals(1, len(self._browser.tabs))
self.assertEquals(existing_tab.url, existing_tab_url)
+ # https://github.com/catapult-project/catapult/issues/3099
+ @decorators.Disabled('android')
def testMultipleTabCalls(self):
self._browser.tabs[0].Navigate(self.UrlOfUnittestFile('blank.html'))
self._browser.tabs[0].WaitForDocumentReadyStateToBeInteractiveOrBetter()
@@ -66,7 +68,9 @@ class BrowserTest(browser_test_case.BrowserTestCase):
tab.Close()
self.assertEquals(1, len(self._browser.tabs))
+ # https://github.com/catapult-project/catapult/issues/3099 (Android)
@decorators.Enabled('has tabs')
+ @decorators.Disabled('android')
def testForegroundTab(self):
# Should be only one tab at this stage, so that must be the foreground tab
original_tab = self._browser.tabs[0]
@@ -92,6 +96,8 @@ class BrowserTest(browser_test_case.BrowserTestCase):
crash_minidump_path = self._browser.GetMostRecentMinidumpPath()
self.assertIsNotNone(crash_minidump_path)
+ # https://github.com/catapult-project/catapult/issues/3099
+ @decorators.Disabled('android')
def testGetSystemInfo(self):
if not self._browser.supports_system_info:
logging.warning(
@@ -156,7 +162,9 @@ class DirtyProfileBrowserTest(browser_test_case.BrowserTestCase):
def CustomizeBrowserOptions(cls, options):
options.profile_type = 'small_profile'
- @decorators.Disabled('chromeos') # crbug.com/243912
+ # https://github.com/catapult-project/catapult/issues/3099 (Android)
+ # crbug.com/243912 (CrOS)
+ @decorators.Disabled('android', 'chromeos')
def testDirtyProfileCreation(self):
self.assertEquals(1, len(self._browser.tabs))

Powered by Google App Engine
This is Rietveld 408576698