telemetry/telemetry/internal/browser/tab_unittest.py - Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/browser/tab_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Add stack traces and more logging Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/browser_unittest.py ('k') | telemetry/telemetry/internal/browser/user_agent_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/browser/tab_unittest.py

diff --git a/telemetry/telemetry/internal/browser/tab_unittest.py b/telemetry/telemetry/internal/browser/tab_unittest.py

index 2692998b4e179eb60b21939a3f77f67ded382088..8efd1eea97f82dceff0ba586cfad72bec633618e 100644

--- a/telemetry/telemetry/internal/browser/tab_unittest.py

+++ b/telemetry/telemetry/internal/browser/tab_unittest.py

@@ -55,6 +55,8 @@ class TabTest(tab_test_case.TabTestCase):

self._tab.Navigate(self.UrlOfUnittestFile('blank.html'))

self._tab.WaitForDocumentReadyStateToBeComplete()

+ # https://github.com/catapult-project/catapult/issues/3099

+ @decorators.Disabled('android')

def testNavigateAndWaitForInteractiveState(self):

self._tab.Navigate(self.UrlOfUnittestFile('blank.html'))

self._tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()

@@ -62,6 +64,8 @@ class TabTest(tab_test_case.TabTestCase):

def testTabBrowserIsRightBrowser(self):

self.assertEquals(self._tab.browser, self._browser)

+ # https://github.com/catapult-project/catapult/issues/3099

+ @decorators.Disabled('android')

def testRendererCrash(self):

self.assertRaises(exceptions.DevtoolsTargetCrashException,

lambda: self._tab.Navigate('chrome://crash',

@@ -86,7 +90,9 @@ class TabTest(tab_test_case.TabTestCase):

'of undefined\n'),

context.exception.message)

+ # https://github.com/catapult-project/catapult/issues/3099

@decorators.Enabled('has tabs')

+ @decorators.Disabled('android')

def testActivateTab(self):

py_utils.WaitFor(lambda: _IsDocumentVisible(self._tab), timeout=5)

new_tab = self._browser.tabs.New()