telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py - Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

Issue 2236493003: [catapult android trybot] Make Telemetry tests run on Android (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Add stack traces and more logging Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/backends/chrome_inspector/memory_backend_unittest.py ('k') | telemetry/telemetry/internal/browser/browser_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

diff --git a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

index 14ffba0a474ef48177580ac9da253ffdb7fc8ac8..67f640f75120432990f7cd45fa17a92f1a789889 100644

--- a/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

+++ b/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py

@@ -39,9 +39,10 @@ class TracingBackendTest(tab_test_case.TabTestCase):

if not self._browser.supports_memory_dumping:

self.skipTest('Browser does not support memory dumping, skipping test.')

- # win-reference: https://github.com/catapult-project/catapult/issues/2409.

+ # android: https://github.com/catapult-project/catapult/issues/3099.

# chromeos: http://crbug.com/622836.

- @decorators.Disabled('win-reference', 'chromeos')

+ # win-reference: https://github.com/catapult-project/catapult/issues/2409.

+ @decorators.Disabled('android', 'chromeos', 'win-reference')

def testDumpMemorySuccess(self):

# Check that dumping memory before tracing starts raises an exception.

self.assertRaises(Exception, self._browser.DumpMemory)