Issue 22364002: Web Animations: Address some review feedback to clean up CSS Animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22364002: Web Animations: Address some review feedback to clean up CSS Animations (Closed)

Created:
7 years, 4 months ago by dstockwell

Modified:
7 years, 4 months ago

Reviewers:
Steve Block

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, leviw+renderwatch, dstockwell, Timothy Loh, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Steve Block, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations: Address some review feedback to clean up CSS Animations Addresses some additional feedback on: https://codereview.chromium.org/21012002 * Add assertions to clarify web-animations only code. * Fix buggy conditional logic when calling setAnimatableStyle on RenderObject. BUG=258896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155582

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -10 lines)			Patch
M	Source/core/animation/ActiveAnimations.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/animation/css/CSSAnimations.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderObject.cpp	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/22364002/1

7 years, 4 months ago (2013-08-06 05:57:00 UTC) #3

Message was sent while issue was closed.

Change committed as 155582

Expand Messages | Collapse Messages