Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 22364002: Web Animations: Address some review feedback to clean up CSS Animations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1717 matching lines...) Expand 10 before | Expand all | Expand 10 after
1728 RenderObjectChildList* childlist = parent()->virtualChildren(); 1728 RenderObjectChildList* childlist = parent()->virtualChildren();
1729 childlist->insertChildNode(parent(), block, this); 1729 childlist->insertChildNode(parent(), block, this);
1730 block->children()->appendChildNode(block, childlist->removeChildNode (parent(), this)); 1730 block->children()->appendChildNode(block, childlist->removeChildNode (parent(), this));
1731 } 1731 }
1732 } 1732 }
1733 } 1733 }
1734 1734
1735 void RenderObject::setAnimatableStyle(PassRefPtr<RenderStyle> style) 1735 void RenderObject::setAnimatableStyle(PassRefPtr<RenderStyle> style)
1736 { 1736 {
1737 if (!isText() && style) { 1737 if (!isText() && style) {
1738 if (RuntimeEnabledFeatures::webAnimationsCSSEnabled() && node() && node( )->isElementNode()) { 1738 if (!RuntimeEnabledFeatures::webAnimationsCSSEnabled()) {
1739 setStyle(animation()->updateAnimations(this, style.get()));
1740 return;
1741 }
1742 if (node() && node()->isElementNode()) {
1739 Element* element = toElement(node()); 1743 Element* element = toElement(node());
1740 if (CSSAnimations::needsUpdate(element, style.get())) 1744 if (CSSAnimations::needsUpdate(element, style.get()))
1741 element->ensureActiveAnimations()->cssAnimations()->update(eleme nt, style.get()); 1745 element->ensureActiveAnimations()->cssAnimations()->update(eleme nt, style.get());
1742 setStyle(style);
1743 } else {
1744 setStyle(animation()->updateAnimations(this, style.get()));
1745 } 1746 }
1746 } else {
1747 setStyle(style);
1748 } 1747 }
1748 setStyle(style);
1749 } 1749 }
1750 1750
1751 StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign ed contextSensitiveProperties) const 1751 StyleDifference RenderObject::adjustStyleDifference(StyleDifference diff, unsign ed contextSensitiveProperties) const
1752 { 1752 {
1753 // If transform changed, and we are not composited, need to do a layout. 1753 // If transform changed, and we are not composited, need to do a layout.
1754 if (contextSensitiveProperties & ContextSensitivePropertyTransform) { 1754 if (contextSensitiveProperties & ContextSensitivePropertyTransform) {
1755 // Text nodes share style with their parents but transforms don't apply to them, 1755 // Text nodes share style with their parents but transforms don't apply to them,
1756 // hence the !isText() check. 1756 // hence the !isText() check.
1757 // FIXME: when transforms are taken into account for overflow, we will n eed to do a layout. 1757 // FIXME: when transforms are taken into account for overflow, we will n eed to do a layout.
1758 if (!isText() && (!hasLayer() || !toRenderLayerModelObject(this)->layer( )->isComposited())) { 1758 if (!isText() && (!hasLayer() || !toRenderLayerModelObject(this)->layer( )->isComposited())) {
(...skipping 1554 matching lines...) Expand 10 before | Expand all | Expand 10 after
3313 { 3313 {
3314 if (object1) { 3314 if (object1) {
3315 const WebCore::RenderObject* root = object1; 3315 const WebCore::RenderObject* root = object1;
3316 while (root->parent()) 3316 while (root->parent())
3317 root = root->parent(); 3317 root = root->parent();
3318 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3318 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3319 } 3319 }
3320 } 3320 }
3321 3321
3322 #endif 3322 #endif
OLDNEW
« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698