Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 22363003: Define V8EXPORT only in v8.h and use it in the other headers (Closed)

Created:
7 years, 4 months ago by yurys
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Define V8EXPORT only in v8.h and use it in the other headers V8EXPORT is defined in each header of V8 public API and the definitions already have some slight discrepancies. This CL makes all headers use the same definition in v8.h BUG=None R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16078

Patch Set 1 #

Patch Set 2 : Comments addressed #

Patch Set 3 : Fixed long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -243 lines) Patch
M include/v8.h View 1 84 chunks +97 lines, -95 lines 0 comments Download
M include/v8-debug.h View 1 2 chunks +1 line, -35 lines 0 comments Download
M include/v8-preparser.h View 1 2 3 chunks +4 lines, -40 lines 0 comments Download
M include/v8-profiler.h View 1 10 chunks +8 lines, -41 lines 0 comments Download
M include/v8-testing.h View 1 2 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 4 months ago (2013-08-06 07:41:47 UTC) #1
Sven Panne
LGTM if we mechanically replace V8EXPORT with V8_EXPORT and add a comment near the top ...
7 years, 4 months ago (2013-08-06 08:34:44 UTC) #2
yurys
On 2013/08/06 08:34:44, Sven Panne wrote: > LGTM if we mechanically replace V8EXPORT with V8_EXPORT ...
7 years, 4 months ago (2013-08-06 14:33:08 UTC) #3
yurys
7 years, 4 months ago (2013-08-06 14:37:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r16078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698