Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: include/v8-testing.h

Issue 22363003: Define V8EXPORT only in v8.h and use it in the other headers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed long line Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8-profiler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-testing.h
diff --git a/include/v8-testing.h b/include/v8-testing.h
index 59eebf9db47774b5a83b208f91badcf282b80f90..97b467a91b151bed9ef03358a9fb384d906c644e 100644
--- a/include/v8-testing.h
+++ b/include/v8-testing.h
@@ -30,42 +30,12 @@
#include "v8.h"
-#ifdef _WIN32
-// Setup for Windows DLL export/import. See v8.h in this directory for
-// information on how to build/use V8 as a DLL.
-#if defined(BUILDING_V8_SHARED) && defined(USING_V8_SHARED)
-#error both BUILDING_V8_SHARED and USING_V8_SHARED are set - please check the\
- build configuration to ensure that at most one of these is set
-#endif
-
-#ifdef BUILDING_V8_SHARED
-#define V8EXPORT __declspec(dllexport)
-#elif USING_V8_SHARED
-#define V8EXPORT __declspec(dllimport)
-#else
-#define V8EXPORT
-#endif
-
-#else // _WIN32
-
-// Setup for Linux shared library export. See v8.h in this directory for
-// information on how to build/use V8 as shared library.
-#if defined(__GNUC__) && ((__GNUC__ >= 4) || \
- (__GNUC__ == 3 && __GNUC_MINOR__ >= 3)) && defined(V8_SHARED)
-#define V8EXPORT __attribute__ ((visibility("default")))
-#else
-#define V8EXPORT
-#endif
-
-#endif // _WIN32
-
-
/**
* Testing support for the V8 JavaScript engine.
*/
namespace v8 {
-class V8EXPORT Testing {
+class V8_EXPORT Testing {
public:
enum StressType {
kStressTypeOpt,
@@ -99,7 +69,7 @@ class V8EXPORT Testing {
} // namespace v8
-#undef V8EXPORT
+#undef V8_EXPORT
#endif // V8_V8_TEST_H_
« no previous file with comments | « include/v8-profiler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698