Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2235743004: [DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed (Closed)

Created:
4 years, 4 months ago by kozy
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed It was presented in Chrome Canary from Feb 2016. More then two stable releases were covered. BUG=635947 R=dgozman@chromium.org Committed: https://crrev.com/fe7762e18384c5e49ac691c83d42d4484aa9c56f Cr-Commit-Position: refs/heads/master@{#411772}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Total comments: 6

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -46 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 4 chunks +5 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 2 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 3 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kozy
Dmitry, please take a look!
4 years, 4 months ago (2016-08-10 22:51:32 UTC) #1
dgozman
Let's do the warning on frontend in getScriptSource. https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (left): https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#oldcode1003 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1003: findSourceURL(scriptSource, ...
4 years, 4 months ago (2016-08-10 23:06:26 UTC) #2
kozy
All done. Please take a look! https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp (left): https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp#oldcode1003 third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1003: findSourceURL(scriptSource, false, &isDeprecatedSourceURL); ...
4 years, 4 months ago (2016-08-12 18:59:32 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/Script.js File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right): https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/Script.js#newcode104 third_party/WebKit/Source/devtools/front_end/sdk/Script.js:104: offset = source.lastIndexOf("\n", offset - 1); linesToCheck-- https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/Script.js#newcode107 ...
4 years, 4 months ago (2016-08-12 19:06:04 UTC) #4
kozy
https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/Script.js File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right): https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/Script.js#newcode104 third_party/WebKit/Source/devtools/front_end/sdk/Script.js:104: offset = source.lastIndexOf("\n", offset - 1); On 2016/08/12 19:06:04, ...
4 years, 4 months ago (2016-08-12 19:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235743004/40001
4 years, 4 months ago (2016-08-12 19:25:36 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 21:17:40 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 21:24:06 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe7762e18384c5e49ac691c83d42d4484aa9c56f
Cr-Commit-Position: refs/heads/master@{#411772}

Powered by Google App Engine
This is Rietveld 408576698