[DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed

[DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed

It was presented in Chrome Canary from Feb 2016. More then two stable releases were covered.

BUG=635947
R=dgozman@chromium.org

Committed: https://crrev.com/fe7762e18384c5e49ac691c83d42d4484aa9c56f
Cr-Commit-Position: refs/heads/master@{#411772}

[kozy, 2016-08-10 22:51:32]

Dmitry, please take a look!

[dgozman, 2016-08-10 23:06:26]

Let's do the warning on frontend in getScriptSource.

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(left):

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1003:
findSourceURL(scriptSource, false, &isDeprecatedSourceURL);
Leave the support please.

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1009:
findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL);
ditto

[kozy, 2016-08-12 18:59:32]

All done. Please take a look!

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(left):

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1003:
findSourceURL(scriptSource, false, &isDeprecatedSourceURL);
On 2016/08/10 23:06:25, dgozman wrote:
> Leave the support please.

Done.

https://codereview.chromium.org/2235743004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1009:
findSourceMapURL(scriptSource, false, &isDeprecatedSourceMappingURL);
On 2016/08/10 23:06:26, dgozman wrote:
> ditto

Done.

[dgozman, 2016-08-12 19:06:04]

lgtm

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:104: offset =
source.lastIndexOf("\n", offset - 1);
linesToCheck--

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:107: if
(sourceTail.search(/^[\040\t]*\/\/@ source(mapping)?url=/mi) === -1)
Let's not do anything if sourceTail is longer than 5000 characters.

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:110: var msg = new
WebInspector.ConsoleMessage(script.target(),
WebInspector.ConsoleMessage.MessageSource.JS,
WebInspector.ConsoleMessage.MessageLevel.Warning, text, undefined, undefined,
undefined, undefined, undefined, undefined, undefined, undefined, undefined,
script.scriptId);
nit: can we have lineNumber and columnNumber so that anchor shows the correct
place?

[kozy, 2016-08-12 19:24:36]

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/Script.js (right):

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:104: offset =
source.lastIndexOf("\n", offset - 1);
On 2016/08/12 19:06:04, dgozman wrote:
> linesToCheck--

Done.

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:107: if
(sourceTail.search(/^[\040\t]*\/\/@ source(mapping)?url=/mi) === -1)
On 2016/08/12 19:06:04, dgozman wrote:
> Let's not do anything if sourceTail is longer than 5000 characters.

Done.

https://codereview.chromium.org/2235743004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/Script.js:110: var msg = new
WebInspector.ConsoleMessage(script.target(),
WebInspector.ConsoleMessage.MessageSource.JS,
WebInspector.ConsoleMessage.MessageLevel.Warning, text, undefined, undefined,
undefined, undefined, undefined, undefined, undefined, undefined, undefined,
script.scriptId);
On 2016/08/12 19:06:04, dgozman wrote:
> nit: can we have lineNumber and columnNumber so that anchor shows the correct
> place?

I'd like to avoid full scan of documents for new lines.

[kozy, 2016-08-12 19:24:39]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-12 19:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2235743004/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-08-12 19:25:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:17:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-12 21:24:06]

Description was changed from

==========
[DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed

It was presented in Chrome Canary from Feb 2016. More then two stable releases
were covered.

BUG=635947
R=dgozman@chromium.org
==========

to

==========
[DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed

It was presented in Chrome Canary from Feb 2016. More then two stable releases
were covered.

BUG=635947
R=dgozman@chromium.org

Committed: https://crrev.com/fe7762e18384c5e49ac691c83d42d4484aa9c56f
Cr-Commit-Position: refs/heads/master@{#411772}
==========

[commit-bot: I haz the power, 2016-08-12 21:24:06]

Patchset 3 (id:??) landed as
https://crrev.com/fe7762e18384c5e49ac691c83d42d4484aa9c56f
Cr-Commit-Position: refs/heads/master@{#411772}