Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Issue 2235743004: [DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
index 037d91036cfde855929d872547f885e08063f6cf..eefff681e684ad6fb5e79fe1fc20d171fcaf5709 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
@@ -13,12 +13,9 @@ namespace blink {
namespace {
-String16 findMagicComment(const String16& content, const String16& name, bool multiline, bool* deprecated)
+String16 findMagicComment(const String16& content, const String16& name, bool multiline)
{
DCHECK(name.find("=") == kNotFound);
- if (deprecated)
- *deprecated = false;
-
unsigned length = content.length();
unsigned nameLength = name.length();
@@ -55,9 +52,6 @@ String16 findMagicComment(const String16& content, const String16& name, bool mu
break;
}
- if (deprecated && content[pos + 2] == '@')
- *deprecated = true;
-
DCHECK(equalSignPos);
DCHECK(!multiline || closingCommentPos);
size_t urlPos = equalSignPos + 1;
@@ -197,14 +191,14 @@ std::vector<std::unique_ptr<protocol::Debugger::SearchMatch>> searchInTextByLine
return result;
}
-String16 findSourceURL(const String16& content, bool multiline, bool* deprecated)
+String16 findSourceURL(const String16& content, bool multiline)
{
- return findMagicComment(content, "sourceURL", multiline, deprecated);
+ return findMagicComment(content, "sourceURL", multiline);
}
-String16 findSourceMapURL(const String16& content, bool multiline, bool* deprecated)
+String16 findSourceMapURL(const String16& content, bool multiline)
{
- return findMagicComment(content, "sourceMappingURL", multiline, deprecated);
+ return findMagicComment(content, "sourceMappingURL", multiline);
}
std::unique_ptr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context, v8::Local<v8::Value> value, int maxDepth)

Powered by Google App Engine
This is Rietveld 408576698