third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h - Issue 2235743004: [DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

Issue 2235743004: [DevTools] Removed deprecatedCommentWasUsed flag from protocol scriptParsed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

index 029ed5661a9e29669e4c1a5ca8b8dca42801546b..d72e175ddf56ada87527b154c5a59676a6eb0630 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

@@ -23,8 +23,8 @@ v8::Local<v8::String> toV8StringInternalized(v8::Isolate*, const char*);

String16 toProtocolString(v8::Local<v8::String>);

String16 toProtocolStringWithTypeCheck(v8::Local<v8::Value>);

-String16 findSourceURL(const String16& content, bool multiline, bool* deprecated = nullptr);

-String16 findSourceMapURL(const String16& content, bool multiline, bool* deprecated = nullptr);

+String16 findSourceURL(const String16& content, bool multiline);

+String16 findSourceMapURL(const String16& content, bool multiline);

std::vector<std::unique_ptr<protocol::Debugger::SearchMatch>> searchInTextByLinesImpl(V8InspectorSession*, const String16& text, const String16& query, bool caseSensitive, bool isRegex);

} // namespace blink