Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2235703002: MIPS: [compiler] [wasm] Introduce Word32/64ReverseBytes as TF Optional Opcode. (Closed)

Created:
4 years, 4 months ago by ivica.bogosavljevic
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [compiler] [wasm] Introduce Word32/64ReverseBytes as TF Optional Opcode. Port 77c9cb8341e85e8e2f1b65d5004ac90e7dc060ea. Original commit message: This commit fixes wasm little-endian load issue on big-endian platform by introducing reverse byte operation immediately after a load. BUG= Committed: https://crrev.com/998f779727e43fcbab2bf9aaa95017a649a7e93c Cr-Commit-Position: refs/heads/master@{#38660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -72 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +27 lines, -25 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +28 lines, -26 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 4 months ago (2016-08-10 11:56:05 UTC) #2
akos.palfi.imgtec
LGTM
4 years, 4 months ago (2016-08-16 10:58:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235703002/1
4 years, 4 months ago (2016-08-16 13:04:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 13:07:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 13:07:45 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/998f779727e43fcbab2bf9aaa95017a649a7e93c
Cr-Commit-Position: refs/heads/master@{#38660}

Powered by Google App Engine
This is Rietveld 408576698