Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2235693002: convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests (Closed)

Created:
4 years, 4 months ago by MuVen
Modified:
4 years, 4 months ago
Reviewers:
Srirama, skobes
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests. BUG=636285 Committed: https://crrev.com/b3424163759b1a2a770d653229d2bad6e613f2ae Cr-Commit-Position: refs/heads/master@{#411287}

Patch Set 1 #

Total comments: 16

Patch Set 2 : addressed review comments #

Total comments: 2

Patch Set 3 : addressed review comments #

Messages

Total messages: 20 (11 generated)
MuVen
PTAL.
4 years, 4 months ago (2016-08-10 10:27:38 UTC) #3
Srirama
may be change description to "convert LayoutTest/scrollbars/* tests to testhearness.js based"? https://codereview.chromium.org/2235693002/diff/20001/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html File third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html (right): ...
4 years, 4 months ago (2016-08-10 11:04:39 UTC) #5
MuVen
PTAL https://codereview.chromium.org/2235693002/diff/20001/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html File third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html (right): https://codereview.chromium.org/2235693002/diff/20001/third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html#newcode2 third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html:2: <head> On 2016/08/10 11:04:38, Srirama wrote: > nit: ...
4 years, 4 months ago (2016-08-10 11:40:59 UTC) #6
Srirama
LGTM and i will leave the final say to skobes.
4 years, 4 months ago (2016-08-10 12:32:34 UTC) #10
skobes
lgtm w/ nit https://codereview.chromium.org/2235693002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html File third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html (left): https://codereview.chromium.org/2235693002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html#oldcode12 third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html:12: Can you keep these blank lines? ...
4 years, 4 months ago (2016-08-10 21:14:14 UTC) #11
MuVen
Done. Committing the changes. https://codereview.chromium.org/2235693002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html File third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html (left): https://codereview.chromium.org/2235693002/diff/40001/third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html#oldcode12 third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html:12: On 2016/08/10 21:14:14, skobes wrote: ...
4 years, 4 months ago (2016-08-11 06:55:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2235693002/60001
4 years, 4 months ago (2016-08-11 06:56:12 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-11 07:59:03 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 08:01:16 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b3424163759b1a2a770d653229d2bad6e613f2ae
Cr-Commit-Position: refs/heads/master@{#411287}

Powered by Google App Engine
This is Rietveld 408576698