third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html - Issue 2235693002: convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content.html

Issue 2235693002: convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fit-content-expected.txt » ('j') | third_party/WebKit/LayoutTests/scrollbars/custom-scrollbar-not-inherited-by-iframe.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/js-test.js"></script>	2 <head>
	Srirama 2016/08/10 11:04:38 nit: html, head and body elements are options, so nit: html, head and body elements are options, so you can omit them (https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...). MuVen 2016/08/10 11:40:58 On 2016/08/10 11:04:38, Srirama wrote: > nit: html Show quoted text On 2016/08/10 11:04:38, Srirama wrote: > nit: html, head and body elements are options, so you can omit them > (https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-...).
	3 <title>Make sure a parent block that fits content expands when a child adds an a uto scrollbar.</title>

	4 </head>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

3 <div id="top" style="float:left; display:none;">	7 <div id="top" style="float:left; display:none;">

4 <div id="scroller" style="overflow: auto; height: 100px;">	8 <div id="scroller" style="overflow: auto; height: 100px;">

5 <div style="width: 100px; height: 200px; border: 2px solid blue;"></div>	9 <div style="width: 100px; height: 200px; border: 2px solid blue;"></div>

6 </div>	10 </div>

7 </div>	11 </div>

8

9 <script>	12 <script>

10 description("Make sure a parent block that fits content expands when a child add s an auto scrollbar.");	13 test(function(){
	Srirama 2016/08/10 11:04:39 nit: add space between () and { nit: add space between () and { MuVen 2016/08/10 11:40:59 Done. Show quoted text On 2016/08/10 11:04:39, Srirama wrote: > nit: add space between () and { Done.
11	14 var topDiv = document.getElementById("top");

12 var topDiv = document.getElementById("top");	15 var scroller = document.getElementById("scroller");

13 var scroller = document.getElementById("scroller");	16 topDiv.style.display = "block";

14 topDiv.style.display = "block";	17 topDiv.offsetTop;

15 topDiv.offsetTop;	18 assert_equals(scroller.clientWidth, scroller.scrollWidth);

16 shouldBe("scroller.clientWidth", "scroller.scrollWidth");	19 });

17 </script>	20 </script>

OLD	NEW