third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html - Issue 2235693002: convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom.html

Issue 2235693002: convert LayoutTest/scrollbars/* js-test.js tests to testharness.js based tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/scrollbars/custom-scrollbar-not-inherited-by-iframe-expected.txt ('k') | third_party/WebKit/LayoutTests/scrollbars/iframe-scrollbar-becomes-custom-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script src="../resources/js-test.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <iframe id="i" frameborder="0" style="margin-top: 10px"></iframe>	3 <script src="../resources/testharnessreport.js"></script>

	4 <iframe frameborder="0" style="margin-top: 10px"></iframe>

4 <div id="content" style="display: none">	5 <div id="content" style="display: none">

5 <div id="block1" style='background-color: #ccc'>100% width</div><br>	6 <div id="block1" style='background-color: #ccc'>100% width</div><br>

6 <div style='background-color: #ddf; width: 400px; height: 300px'></div>	7 <div style='background-color: #ddf; width: 400px; height: 300px'></div>

7 </div>	8 </div>

8 <script>	9 <script>

	10 test(function() {

	11 var iframedoc = document.querySelector("iframe").contentDocument;

	12 var sheet = iframedoc.head.appendChild(iframedoc.createElement("style")).she et;

	13 iframedoc.body.style.margin = "0";

	14 iframedoc.body.innerHTML = document.querySelector("#content").innerHTML;

	15 var block = iframedoc.querySelector("#block1");

	16 var origWidth = block.offsetWidth;

	17 sheet.insertRule("::-webkit-scrollbar { width: 50px; height: 20px; }", 0);

	18 sheet.insertRule("::-webkit-scrollbar-thumb { background: #cce; }", 1);

	19 var width = block.offsetWidth;

9	20

10 var idoc = document.querySelector("#i").contentDocument;	21 assert_equals(250, width);

11 var sheet = idoc.head.appendChild(idoc.createElement("style")).sheet;	22 assert_less_than(width, origWidth);

12	23 });
skobes 2016/08/10 21:14:14 Can you keep these blank lines? They make it easi Can you keep these blank lines? They make it easier to read. MuVen 2016/08/11 06:55:12 Done. Show quoted text On 2016/08/10 21:14:14, skobes wrote: > Can you keep these blank lines? They make it easier to read. Done.
13 idoc.body.style.margin = '0';

14 idoc.body.innerHTML = document.querySelector('#content').innerHTML;

15

16 var block = idoc.querySelector("#block1");

17 var origWidth = block.offsetWidth;

18

19 sheet.insertRule("::-webkit-scrollbar { width: 50px; height: 20px; }", 0);

20 sheet.insertRule("::-webkit-scrollbar-thumb { background: #cce; }", 1);

21

22 var width = block.offsetWidth;

23

24 shouldBe("250", String(width));

25 shouldBeTrue("width < origWidth");

26

27 </script>	24 </script>

OLD	NEW