third_party/WebKit/Source/wtf/text/WTFString.h - Issue 2235113002: Use StringView for String::append and ::insert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2235113002: Use StringView for String::append and ::insert. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix appendHex stuff. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFString.h

diff --git a/third_party/WebKit/Source/wtf/text/WTFString.h b/third_party/WebKit/Source/wtf/text/WTFString.h

index b5aa5a9e77976542ac08e096b0bf066d3a7e9499..6fe2cea67587ef63787983edea480313c0045e30 100644

--- a/third_party/WebKit/Source/wtf/text/WTFString.h

+++ b/third_party/WebKit/Source/wtf/text/WTFString.h

@@ -220,16 +220,11 @@ public:

bool endsWith(UChar character) const

{ return m_impl ? m_impl->endsWith(character) : false; }

- void append(const String&);

+ void append(const StringView&);

void append(LChar);

void append(char c) { append(static_cast<LChar>(c)); }

void append(UChar);

- void append(const LChar*, unsigned length);

- void append(const char* charactersToAppend, unsigned length) { append(reinterpret_cast<const LChar*>(charactersToAppend), length); }

- void append(const UChar*, unsigned length);

- void insert(const String&, unsigned pos);

- void insert(const LChar*, unsigned length, unsigned pos);

- void insert(const UChar*, unsigned length, unsigned pos);

+ void insert(const StringView&, unsigned pos);

String& replace(UChar a, UChar b)

{