third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp - Issue 2235113002: Use StringView for String::append and ::insert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

Issue 2235113002: Use StringView for String::append and ::insert. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix appendHex stuff. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

index 1f21f65553a1b84b413e63c4d0f2dfa3160abfcf..da2801801e688735932b30b100799b3e59914b64 100644

--- a/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

+++ b/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp

@@ -301,9 +301,11 @@ std::unique_ptr<JSONObject> objectForSkShader(const SkShader& shader)

String stringForSkColor(const SkColor& color)

{

- String colorString = "#";

- appendUnsignedAsHex(color, colorString);

- return colorString;

+ // #AARRGGBB.

+ Vector<LChar, 9> result;

+ result.append('#');

+ appendUnsignedAsHex(color, result);

+ return String(result.data(), result.size());

}

void appendFlagToString(String* flagsString, bool isSet, const String& name)