Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/wtf/text/WTFString.h

Issue 2235113002: Use StringView for String::append and ::insert. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix appendHex stuff. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 bool startsWith(const StringView& prefix, TextCaseSensitivity caseSensitivit y = TextCaseSensitive) const 213 bool startsWith(const StringView& prefix, TextCaseSensitivity caseSensitivit y = TextCaseSensitive) const
214 { return m_impl ? DISPATCH_CASE_OP(caseSensitivity, m_impl->startsWith, (prefix)) : prefix.isEmpty(); } 214 { return m_impl ? DISPATCH_CASE_OP(caseSensitivity, m_impl->startsWith, (prefix)) : prefix.isEmpty(); }
215 bool startsWith(UChar character) const 215 bool startsWith(UChar character) const
216 { return m_impl ? m_impl->startsWith(character) : false; } 216 { return m_impl ? m_impl->startsWith(character) : false; }
217 217
218 bool endsWith(const StringView& suffix, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const 218 bool endsWith(const StringView& suffix, TextCaseSensitivity caseSensitivity = TextCaseSensitive) const
219 { return m_impl ? DISPATCH_CASE_OP(caseSensitivity, m_impl->endsWith, (s uffix)) : suffix.isEmpty(); } 219 { return m_impl ? DISPATCH_CASE_OP(caseSensitivity, m_impl->endsWith, (s uffix)) : suffix.isEmpty(); }
220 bool endsWith(UChar character) const 220 bool endsWith(UChar character) const
221 { return m_impl ? m_impl->endsWith(character) : false; } 221 { return m_impl ? m_impl->endsWith(character) : false; }
222 222
223 void append(const String&); 223 void append(const StringView&);
224 void append(LChar); 224 void append(LChar);
225 void append(char c) { append(static_cast<LChar>(c)); } 225 void append(char c) { append(static_cast<LChar>(c)); }
226 void append(UChar); 226 void append(UChar);
227 void append(const LChar*, unsigned length); 227 void insert(const StringView&, unsigned pos);
228 void append(const char* charactersToAppend, unsigned length) { append(reinte rpret_cast<const LChar*>(charactersToAppend), length); }
229 void append(const UChar*, unsigned length);
230 void insert(const String&, unsigned pos);
231 void insert(const LChar*, unsigned length, unsigned pos);
232 void insert(const UChar*, unsigned length, unsigned pos);
233 228
234 String& replace(UChar a, UChar b) 229 String& replace(UChar a, UChar b)
235 { 230 {
236 if (m_impl) 231 if (m_impl)
237 m_impl = m_impl->replace(a, b); 232 m_impl = m_impl->replace(a, b);
238 return *this; 233 return *this;
239 } 234 }
240 String& replace(UChar a, const String& b) 235 String& replace(UChar a, const String& b)
241 { 236 {
242 if (m_impl) 237 if (m_impl)
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
597 using WTF::emptyString16Bit; 592 using WTF::emptyString16Bit;
598 using WTF::append; 593 using WTF::append;
599 using WTF::charactersAreAllASCII; 594 using WTF::charactersAreAllASCII;
600 using WTF::equal; 595 using WTF::equal;
601 using WTF::find; 596 using WTF::find;
602 using WTF::isAllSpecialCharacters; 597 using WTF::isAllSpecialCharacters;
603 using WTF::isSpaceOrNewline; 598 using WTF::isSpaceOrNewline;
604 599
605 #include "wtf/text/AtomicString.h" 600 #include "wtf/text/AtomicString.h"
606 #endif // WTFString_h 601 #endif // WTFString_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698