Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 2234843002: Revert of Change mapRectScaleTranslate to pass args/ret by value (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
msarett, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Change mapRectScaleTranslate to pass args/ret by value (patchset #2 id:20001 of https://codereview.chromium.org/2138943002/ ) Reason for revert: Build-Ubuntu-GCC-Arm7-Release-Android fails. Original issue's description: > Change mapRectScaleTranslate to pass args/ret by value > > This reverts commit 6092b6e0e57be20d2e1ad079c0af133d2f67bfd3. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2138943002 > > Committed: https://skia.googlesource.com/skia/+/1bd13ca922d6448d595064faee486eaf3fa56e56 TBR=mtklein@google.com,msarett@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c5769b2e49a63516f313f42969983f2b9e4d59e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M bench/MatrixBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
hal.canary
Created Revert of Change mapRectScaleTranslate to pass args/ret by value
4 years, 4 months ago (2016-08-10 14:13:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2234843002/1
4 years, 4 months ago (2016-08-10 14:13:17 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:13:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c5769b2e49a63516f313f42969983f2b9e4d59e0

Powered by Google App Engine
This is Rietveld 408576698