include/core/SkMatrix.h - Issue 2234843002: Revert of Change mapRectScaleTranslate to pass args/ret by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkMatrix.h

Issue 2234843002: Revert of Change mapRectScaleTranslate to pass args/ret by value (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkMatrix.h

diff --git a/include/core/SkMatrix.h b/include/core/SkMatrix.h

index 8f70d4c91b0a995c35ee7c11fb30c570477f5901..5b22a774814de5c02111d0e3c656b10f90526551 100644

--- a/include/core/SkMatrix.h

+++ b/include/core/SkMatrix.h

@@ -565,7 +565,7 @@

* Maps a rect to another rect, asserting (in debug mode) that the matrix only contains

* scale and translate elements. If it contains other elements, the results are undefined.

- SkRect mapRectScaleTranslate(SkRect src) const;

+ void mapRectScaleTranslate(SkRect* dst, const SkRect& src) const;

/** Return the mean radius of a circle after it has been mapped by

this matrix. NOTE: in perspective this value assumes the circle

« no previous file with comments | « bench/MatrixBench.cpp ('k') | src/core/SkCanvas.cpp » ('j') | no next file with comments »